Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 2324733003: explicit operator bool for CFX_RetainPtr and CFX_CountRef (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

explicit operator bool for CFX_RetainPtr and CFX_CountRef Committed: https://pdfium.googlesource.com/pdfium/+/cf7ac195266fe05f7548c531df32c2b4aa4b5608

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M core/fxcrt/cfx_retain_ptr_unittest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxcrt/include/cfx_count_ref.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/include/cfx_retain_ptr.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Lei, quick review.
4 years, 3 months ago (2016-09-08 20:14:50 UTC) #2
Lei Zhang
lgtm
4 years, 3 months ago (2016-09-08 21:03:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324733003/1
4 years, 3 months ago (2016-09-08 22:34:47 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 22:47:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/cf7ac195266fe05f7548c531df32c2b4aa4b...

Powered by Google App Engine
This is Rietveld 408576698