core/fxcrt/include/cfx_count_ref.h - Issue 2324733003: explicit operator bool for CFX_RetainPtr and CFX_CountRef

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/include/cfx_count_ref.h

Issue 2324733003: explicit operator bool for CFX_RetainPtr and CFX_CountRef (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcrt/include/cfx_count_ref.h

diff --git a/core/fxcrt/include/cfx_count_ref.h b/core/fxcrt/include/cfx_count_ref.h

index 95132a73ca0e34983199c12fb878d2944fdf062a..d709efb67c0c9d1d64554d507ad0892ec3063c4b 100644

--- a/core/fxcrt/include/cfx_count_ref.h

+++ b/core/fxcrt/include/cfx_count_ref.h

@@ -47,7 +47,7 @@ class CFX_CountRef {

return m_pObject == that.m_pObject;

}

bool operator!=(const CFX_CountRef& that) const { return !(*this == that); }

- operator bool() const { return m_pObject; }

+ explicit operator bool() const { return !!m_pObject; }

private:

class CountedObj : public ObjClass {

« no previous file with comments | « core/fxcrt/cfx_retain_ptr_unittest.cpp ('k') | core/fxcrt/include/cfx_retain_ptr.h » ('j') | no next file with comments »