Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2324623003: Revert of Mojo C++ Bindings: Additional support for associated binding sets (Closed)

Created:
4 years, 3 months ago by lushnikov
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mojo C++ Bindings: Additional support for associated binding sets (patchset #2 id:20001 of https://codereview.chromium.org/2309513002/ ) Reason for revert: This broke compilation on Win x64 builder: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/94511 Original issue's description: > Mojo C++ Bindings: Additional support for associated binding sets > > Implements three orthogonal changes to the public bindings API: > > 1. Adds the ability to remove bindings from a binding set. Uses > a new mojo::BindingId integer alias to identify added bindings. > > 2. Adds the ability to set a pre-dispatch hook on binding sets. > In some cases simply making the dispatch_context() available > is insufficient, for example when a consumer owns multiple > binding sets and wants a common path for establishing context > among any of them. > > 3. Adds mojo::GetDummyProxy, a helper that can bind an > AssociatedInterfacePtr<T> so that it has some valid internal > state and silently drops all outgoing messages. Unlike > regular message pipe interfaces, without this feature > associated interfaces are difficult to stub out in test > environments. > > Part a series of CLs to enable and demonstrate WebContents associated > interfaces: > > 1. https://codereview.chromium.org/2301123004 > 2. This CL > 3. https://codereview.chromium.org/2310563002 > 4. https://codereview.chromium.org/2310583002 > > BUG=612500 > R=yzshen@chromium.org > > Committed: https://crrev.com/4b8bca190cdc55bae81974aa09cc10f422f022fb > Cr-Commit-Position: refs/heads/master@{#417126} TBR=yzshen@chromium.org,rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612500 Committed: https://crrev.com/c08a3abcbc9d79e2a7031b116d0af9ee92d17459 Cr-Commit-Position: refs/heads/master@{#417135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -64 lines) Patch
M mojo/public/cpp/bindings/associated_interface_ptr.h View 2 chunks +0 lines, -13 lines 0 comments Download
M mojo/public/cpp/bindings/binding_set.h View 6 chunks +12 lines, -51 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
lushnikov
Created Revert of Mojo C++ Bindings: Additional support for associated binding sets
4 years, 3 months ago (2016-09-08 01:01:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324623003/1
4 years, 3 months ago (2016-09-08 01:02:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 01:02:59 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c08a3abcbc9d79e2a7031b116d0af9ee92d17459 Cr-Commit-Position: refs/heads/master@{#417135}
4 years, 3 months ago (2016-09-08 01:05:09 UTC) #7
lushnikov
4 years, 3 months ago (2016-09-08 01:14:02 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2320723003/ by lushnikov@chromium.org.

The reason for reverting is: It seems like linker just occasionally ran out of
memory on the buildbot. The CL seems to be innocent. .

Powered by Google App Engine
This is Rietveld 408576698