Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2324623002: Disallow reentrance of FrameView::updateLifecyclePhasesInternal() (Closed)

Created:
4 years, 3 months ago by Xianzhu
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Disallow reentrance of FrameView::updateLifecyclePhasesInternal() Reentrance of FrameView::updateLifecyclePhasesInternal() is bad. For example, when we are invalidating paint, we call a function which looks like a non-side-affecting getter which unexpectedly initiates another lifecycle update which may unexpectedly delete the object that the caller is processing. This CL checks reentrance of FrameView::updateLifecyclePhasesInternal(), and crash with NOTREACHED() if DCHECK is enabled or early return otherwise. BUG=590856, 621360 Review-Url: https://codereview.chromium.org/2310453002 Cr-Commit-Position: refs/heads/master@{#416712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Xianzhu
4 years, 3 months ago (2016-09-07 22:51:29 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
1c038161ca3bb2ee8118ede9d051ac134253d834.

Powered by Google App Engine
This is Rietveld 408576698