Disallow reentrance of FrameView::updateLifecyclePhasesInternal()

third_party/WebKit/Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 2544 matching lines @@
         if (FrameView* frameView = m_frame->view())
             frameView->scheduleAnimation();
     }
 
     DCHECK(!layoutView()->needsLayout());
 }
 
 // TODO(leviw): We don't assert lifecycle information from documents in child PluginViews.
 void FrameView::updateLifecyclePhasesInternal(DocumentLifecycle::LifecycleState targetState)
 {
+    if (m_currentUpdateLifecyclePhasesTargetState != DocumentLifecycle::Uninitialized) {
+        NOTREACHED() << "FrameView::updateLifecyclePhasesInternal() reentrance";
+        return;
+    }
+
     // This must be called from the root frame, since it recurses down, not up.
     // Otherwise the lifecycles of the frames might be out of sync.
     DCHECK(m_frame->isLocalRoot());
 
     // Only the following target states are supported.
     DCHECK(targetState == DocumentLifecycle::LayoutClean
         || targetState == DocumentLifecycle::CompositingClean
         || targetState == DocumentLifecycle::PrePaintClean
         || targetState == DocumentLifecycle::PaintClean);
 
@@ skipping 1749 matching lines @@
 }
 
 bool FrameView::canThrottleRendering() const
 {
     if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled())
         return false;
     return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrottling);
 }
 
 } // namespace blink