codereview.settings: add GIT_NUMBER_FOOTER setting.

codereview.settings: add GIT_NUMBER_FOOTER setting.

This will be used in repositories that use Cr-Commit-Position footers
to generate them at the time of git cl land instead of gnumbd.

R=iannucci@chromium.org
BUG=642493
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/f46c20fcee6e6a0a7d75788847632cd4ac18e2e9

[tandrii(chromium), 2016-09-07 21:27:40]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 21:27:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 21:41:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 21:41:54]

Dry run: Try jobs failed on following builders:
  Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/311f5e5835734810)

[tandrii(chromium), 2016-09-09 20:14:11]

PTAL

[iannucci, 2016-09-09 22:11:43]

Is this only temporary for rietveld? If so, then lgtm. If it's going to hang
around during gerrit, then that's sad... Could we instead look at the first
remote upstream to see if gnumbd is turned on or not?

[tandrii(chromium), 2016-09-09 22:16:57]

On 2016/09/09 22:11:43, iannucci wrote:
> Is this only temporary for rietveld? If so, then lgtm. If it's going to hang
> around during gerrit, then that's sad... Could we instead look at the first
> remote upstream to see if gnumbd is turned on or not?

See TODO in code. This will be alive while both Rietveld and Gerrit are
operational, but will be killed once Rietveld is read-only for gnumbd-projects.

[tandrii(chromium), 2016-09-09 22:17:03]

https://codereview.chromium.org/2324583002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2324583002/diff/1/git_cl.py#newcode886
git_cl.py:886: # TODO(tandrii): this has to be removed after Rietveld is
read-only.
only while Rietveld Cls can be landed.

[iannucci, 2016-09-09 22:23:20]

On 2016/09/09 at 22:17:03, tandrii wrote:
> https://codereview.chromium.org/2324583002/diff/1/git_cl.py
> File git_cl.py (right):
> 
> https://codereview.chromium.org/2324583002/diff/1/git_cl.py#newcode886
> git_cl.py:886: # TODO(tandrii): this has to be removed after Rietveld is
read-only.
> only while Rietveld Cls can be landed.

Yes I saw, I was just clarifying :)

[tandrii(chromium), 2016-09-14 13:13:48]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-09-14 13:13:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 13:17:07]

Description was changed from

==========
codereview.settings: add GIT_NUMBER_FOOTER setting.

This will be used in repositories that use Cr-Commit-Position footers
to generate them at the time of git cl land instead of gnumbd.

R=iannucci@chromium.org
BUG=642493
==========

to

==========
codereview.settings: add GIT_NUMBER_FOOTER setting.

This will be used in repositories that use Cr-Commit-Position footers
to generate them at the time of git cl land instead of gnumbd.

R=iannucci@chromium.org
BUG=642493

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/f46c20fcee6e6a...
==========

[commit-bot: I haz the power, 2016-09-14 13:17:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/f46c20fcee6e6a...