Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: git_cl.py

Issue 2324583002: codereview.settings: add GIT_NUMBER_FOOTER setting. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 07c528c36f55f38af2af6d12f03a1f81dcbe0238..6cfb4bedb8a5e90b5f50a52258bffb90e51e1c83 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -646,6 +646,7 @@ class Settings(object):
self.project = None
self.force_https_commit_url = None
self.pending_ref_prefix = None
+ self.git_number_footer = None
def LazyUpdateIfNeeded(self):
"""Updates the settings from a codereview.settings file, if available."""
@@ -881,6 +882,14 @@ class Settings(object):
'pending-ref-prefix', error_ok=True)
return self.pending_ref_prefix
+ def GetHasGitNumberFooter(self):
+ # TODO(tandrii): this has to be removed after Rietveld is read-only.
tandrii(chromium) 2016/09/09 22:17:03 only while Rietveld Cls can be landed.
+ # see also bugs http://crbug.com/642493 and http://crbug.com/600469.
+ if not self.git_number_footer:
+ self.git_number_footer = self._GetRietveldConfig(
+ 'git-number-footer', error_ok=True)
+ return self.git_number_footer
+
def _GetRietveldConfig(self, param, **kwargs):
return self._GetConfig('rietveld.' + param, **kwargs)
@@ -2953,6 +2962,7 @@ def LoadCodereviewSettingsFromFile(fileobj):
SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
SetProperty('project', 'PROJECT', unset_error_ok=True)
SetProperty('pending-ref-prefix', 'PENDING_REF_PREFIX', unset_error_ok=True)
+ SetProperty('git-number-footer', 'GIT_NUMBER_FOOTER', unset_error_ok=True)
SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
unset_error_ok=True)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698