Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1346)

Issue 2324553002: Push usage of GrColor4f into OverrideInput (Closed)

Created:
4 years, 3 months ago by Brian Osman
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Push usage of GrColor4f into OverrideInput Just a change to preserve precision. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324553002 Committed: https://skia.googlesource.com/skia/+/4cea3b9e9d9836c926a8feb55d050993d40b4b5e

Patch Set 1 #

Patch Set 2 : Remove TODO comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -19 lines) Patch
M include/gpu/GrColor.h View 1 chunk +11 lines, -0 lines 0 comments Download
M include/gpu/GrFragmentProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrFragmentProcessor.cpp View 3 chunks +8 lines, -15 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Brian Osman
Working on gamut conversion of paint color, so I'm poking around in paint conversion, and ...
4 years, 3 months ago (2016-09-07 20:25:51 UTC) #3
bsalomon
lgtm
4 years, 3 months ago (2016-09-08 15:33:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324553002/20001
4 years, 3 months ago (2016-09-08 16:32:55 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 16:33:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4cea3b9e9d9836c926a8feb55d050993d40b4b5e

Powered by Google App Engine
This is Rietveld 408576698