Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2324523002:
MD Settings: restore super important about page functionality (Closed)
|
Created:
4 years, 3 months ago by Dan Beam Modified:
4 years, 3 months ago CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: restore super important about page functionality
R=hcarmona@chromium.org
BUG=643651
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/05fc08750bd6c061013232ed4879b4e73f47e94b
Cr-Commit-Position: refs/heads/master@{#417153}
Patch Set 1 : typo #
Total comments: 2
Dependent Patchsets: Messages
Total messages: 22 (13 generated)
Description was changed from ========== MD Settings: restore super important about page functionality R=hcarmona@chromium.org BUG=643651 ========== to ========== MD Settings: restore super important about page functionality R=hcarmona@chromium.org BUG=643651 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
LGTM
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== MD Settings: restore super important about page functionality R=hcarmona@chromium.org BUG=643651 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: restore super important about page functionality R=hcarmona@chromium.org BUG=643651 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/05fc08750bd6c061013232ed4879b4e73f47e94b Cr-Commit-Position: refs/heads/master@{#417153} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/05fc08750bd6c061013232ed4879b4e73f47e94b Cr-Commit-Position: refs/heads/master@{#417153}
Message was sent while issue was closed.
alancutter@chromium.org changed reviewers: + alancutter@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2324523002/diff/60001/chrome/browser/resource... File chrome/browser/resources/settings/about_page/about_page.js (right): https://codereview.chromium.org/2324523002/diff/60001/chrome/browser/resource... chrome/browser/resources/settings/about_page/about_page.js:288: logo.classList.add('spin'); If this doesn't get run on iOS you could write this as: logo.animate({transform: ['none', 'rotate(-10turn)']}, { duration: 500, easing: 'cubic-bezier(1, 0, 0, 1)', }); I don't think the fill forwards is necessary since the end state looks identical to the non-animated state.
Message was sent while issue was closed.
https://codereview.chromium.org/2324523002/diff/60001/chrome/browser/resource... File chrome/browser/resources/settings/about_page/about_page.js (right): https://codereview.chromium.org/2324523002/diff/60001/chrome/browser/resource... chrome/browser/resources/settings/about_page/about_page.js:288: logo.classList.add('spin'); On 2016/09/08 01:58:47, alancutter wrote: > If this doesn't get run on iOS you could write this as: > logo.animate({transform: ['none', 'rotate(-10turn)']}, { > duration: 500, > easing: 'cubic-bezier(1, 0, 0, 1)', > }); > > I don't think the fill forwards is necessary since the end state looks identical > to the non-animated state. Okie dokie: https://codereview.chromium.org/2321913003 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
