Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issue 2321913003: Old and new about pages: simplify product logo animation code (Closed)

Created:
4 years, 3 months ago by Dan Beam
Modified:
4 years, 3 months ago
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Old and new about pages: simplify product logo animation code Also removes class toggling hackery. R=alancutter@chromium.org BUG=643651 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOPRESUBMIT=true Committed: https://crrev.com/bc155b656b3454845df2d3e827291eea3829f899 Cr-Commit-Position: refs/heads/master@{#417480}

Patch Set 1 #

Patch Set 2 : happify closure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -32 lines) Patch
M chrome/browser/resources/help/help_content.css View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/help/help_page.js View 1 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/compiled_resources.gyp View 1 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/about_page/about_page.html View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/settings/about_page/about_page.js View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/about_page/compiled_resources2.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (15 generated)
Dan Beam
4 years, 3 months ago (2016-09-08 17:41:45 UTC) #2
alancutter (OOO until 2018)
lgtm
4 years, 3 months ago (2016-09-09 01:45:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321913003/20001
4 years, 3 months ago (2016-09-09 01:46:54 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/256211)
4 years, 3 months ago (2016-09-09 02:01:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321913003/20001
4 years, 3 months ago (2016-09-09 02:27:27 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 02:28:44 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 02:30:57 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bc155b656b3454845df2d3e827291eea3829f899
Cr-Commit-Position: refs/heads/master@{#417480}

Powered by Google App Engine
This is Rietveld 408576698