Propagate use_relative_paths into recursedeps

Propagate use_relative_paths into recursedeps

Currently, if a DEPS file sets use_relative_paths, but *also* sets
recursedeps, then the recursed-upon DEPS files still get checked
out relative to the .gclient root. This change makes it so that
recursed-upon DEPS files check their dependencies out relative to
where their parent wants them to be, if that parent sets
use_relative_paths=True.

R=maruel@chromium.org

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/dce6ddcd21d71688aed5fd10b7cb1216275639ef

[iannucci, 2016-09-07 19:08:21]

iannucci@chromium.org changed reviewers:
+ iannucci@chromium.org

[iannucci, 2016-09-07 19:08:21]

oof.... lgtm. When can we start deleting code?

[M-A Ruel, 2016-09-07 19:10:20]

This is quite a core functionality change, has no test and there are no use case
explained.

Closing my eyes and lgtm.

[agable, 2016-09-07 19:40:49]

Use case is in an email thread on chrome-infra@. If you have a DEPS file which
looks like

"""
use_relative_paths = True
deps = {
  'chromium/src':
'https://chromium.googlesource.com/chromium/src.git@68623971be0cfc492a2cb0427d7f478e7b214c24',
}
"""

then you end up with a directory structure which looks like 

root/
  DEPS
  chromium/
    src/
      DEPS
      <other contents of src.git>
src/
  <things listed in src.git's DEPS>

That's obviously not intended. This change makes it to that the recursedeps
respects use_relative_paths (unless the recursed-upon DEPS itself sets
use_relative_paths, in which case that takes priority) so that the recursed-upon
DEPS get checked out like they would if the repo were a top-level solution, as
so:

root/
  DEPS
  chromium/
    src/
      DEPS
      <other contents of src.git>
      <things listed in src.git's DEPS>

which is obviously more desired.

This only affects files which contain *both* use_relative_paths *and*
recursedeps, *and* whose recursive dependencies *don't* themselves set
use_relative_paths.

Will add a new unit test before landing.

[agable, 2016-09-07 19:56:20]

Also, there's only one file which this *could* affect in chromium/src:
$ cd src
$ find . -name DEPS | xargs grep recursedeps
./v8/DEPS:recursedeps = [ 'v8/third_party/android_tools' ]
./DEPS:recursedeps = [
./third_party/skia/DEPS:recursedeps = [ "common" ]
$ find . -name DEPS | xargs grep use_relative_paths
./buildtools/DEPS:use_relative_paths = True
./third_party/pdfium/DEPS:use_relative_paths = True
./third_party/skia/DEPS:use_relative_paths = True

So it looks like this could affect Skia, but chromium doesn't actually recurse
on Skia in the first place. And Skia's common/DEPS does also set
use_relative_paths, so it won't be affected in their standalone checkouts.

[agable, 2016-09-07 22:35:02]

Just uploaded a new patchset which introduces a new test.

It turns out that we were already testing a combination of recursedeps +
use_relative_paths behavior, but
1) We weren't asserting anything about the path at which deps were checked out
(fixed by https://codereview.chromium.org/2316963004)
2) We weren't populating repos with DEPS files in the correct place, so the test
framework thought there was no DEPS file to recurse upon (fixed by the new
patchset)

[M-A Ruel, 2016-09-07 23:52:50]

lgtm

[iannucci, 2016-09-08 00:01:20]

thanks for adding a test... I was dumb for not asking :(

lgtm

[agable, 2016-09-08 16:59:08]

The CQ bit was checked by agable@chromium.org

[commit-bot: I haz the power, 2016-09-08 16:59:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 17:02:19]

Description was changed from

==========
Propagate use_relative_paths into recursedeps

Currently, if a DEPS file sets use_relative_paths, but *also* sets
recursedeps, then the recursed-upon DEPS files still get checked
out relative to the .gclient root. This change makes it so that
recursed-upon DEPS files check their dependencies out relative to
where their parent wants them to be, if that parent sets
use_relative_paths=True.

R=maruel@chromium.org
==========

to

==========
Propagate use_relative_paths into recursedeps

Currently, if a DEPS file sets use_relative_paths, but *also* sets
recursedeps, then the recursed-upon DEPS files still get checked
out relative to the .gclient root. This change makes it so that
recursed-upon DEPS files check their dependencies out relative to
where their parent wants them to be, if that parent sets
use_relative_paths=True.

R=maruel@chromium.org

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/dce6ddcd21d716...
==========

[commit-bot: I haz the power, 2016-09-08 17:02:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/dce6ddcd21d716...