Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2316963004: Update gclient test to assert both dir and url (Closed)

Created:
4 years, 3 months ago by agable
Modified:
4 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update gclient test to assert both dir and url This makes it easier to reason about tests which care about both the url being fetched and the directory to which it is being fetched, like those concerning relative paths and recursion. R=maruel@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/73baf8534877e82eb7c4e96aba0f122e39f6e2ee

Patch Set 1 #

Patch Set 2 : Remove pass #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -49 lines) Patch
M tests/gclient_test.py View 1 12 chunks +53 lines, -49 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
agable
4 years, 3 months ago (2016-09-07 22:18:06 UTC) #1
M-A Ruel
lgtm
4 years, 3 months ago (2016-09-07 23:53:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316963004/20001
4 years, 3 months ago (2016-09-07 23:54:39 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/311fe57655fe5410)
4 years, 3 months ago (2016-09-07 23:57:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316963004/20001
4 years, 3 months ago (2016-09-08 16:50:28 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 16:54:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/73baf8534877e8...

Powered by Google App Engine
This is Rietveld 408576698