components/offline_pages/background/request_notifier.h - Issue 2324493005: [Offline Pages] Adds event logs for requests dropped due to number of start or complete attempts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_notifier.h

Issue 2324493005: [Offline Pages] Adds event logs for requests dropped due to number of start or complete attempts. (Closed)

Patch Set: Addresses dimich feedback Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/background/request_notifier.h

diff --git a/components/offline_pages/background/request_notifier.h b/components/offline_pages/background/request_notifier.h

index af74f273ddf1208ea04161a8f206c2c8bdd30a82..7ed907dec954fe7f5a9363fd6e64b90b2fecf9b7 100644

--- a/components/offline_pages/background/request_notifier.h

+++ b/components/offline_pages/background/request_notifier.h

@@ -12,6 +12,8 @@ class SavePageRequest;

class RequestNotifier {

public:

// Status to return for failed notifications.

+ // NOTE: for any changes to the enum, please also update related switch code

+ // in RequestCoordinatorEventLogger.

enum class BackgroundSavePageResult {

SUCCESS,

PRERENDER_FAILURE,