[Offline Pages] Adds event logs for requests dropped due to number of start or complete attempts.

components/offline_pages/background/request_coordinator_event_logger_unittest.cc

Index: components/offline_pages/background/request_coordinator_event_logger_unittest.cc
diff --git a/components/offline_pages/background/request_coordinator_event_logger_unittest.cc b/components/offline_pages/background/request_coordinator_event_logger_unittest.cc
index b04e6b6e8d8c1625e9bba801994536c4cb54c856..e41702b49fb7b94b1b4704d8931d463d635eef46 100644
--- a/components/offline_pages/background/request_coordinator_event_logger_unittest.cc
+++ b/components/offline_pages/background/request_coordinator_event_logger_unittest.cc
@@ -11,17 +11,19 @@ namespace offline_pages {
 namespace {
 
 const char kNamespace[] = "last_n";
-const Offliner::RequestStatus kStatus = Offliner::SAVED;
+const Offliner::RequestStatus kOfflinerStatus = Offliner::SAVED;
+const RequestNotifier::BackgroundSavePageResult kDroppedResult =
+    RequestNotifier::BackgroundSavePageResult::START_COUNT_EXCEEDED;
 const int64_t kId = 1234;
-const RequestQueue::UpdateRequestResult kUpdateResult =
+const RequestQueue::UpdateRequestResult kQueueUpdateResult =
     RequestQueue::UpdateRequestResult::STORE_FAILURE;
 
-const char kStatusLogString[] =
-    "Save page request for ID: 1234 and namespace: "
-    "last_n has been updated with status SAVED";
-const char kUpdateResultLogString[] =
-    "Updating queued request for namespace: last_n failed with result: "
-    "STORE_FAILURE";
+const char kOfflinerStatusLogString[] =
+    "Background save attempt for last_n:1234 - SAVED";
+const char kDroppedResultLogString[] =
+    "Background save request removed last_n:1234 - START_COUNT_EXCEEDED";
+const char kQueueUpdateResultLogString[] =
+    "Updating queued request for last_n failed - STORE_FAILURE";
 const int kTimeLength = 21;
 
 }  // namespace
@@ -31,13 +33,16 @@ TEST(RequestCoordinatorEventLoggerTest, RecordsWhenLoggingIsOn) {
   std::vector<std::string> log;
 
   logger.SetIsLogging(true);
-  logger.RecordSavePageRequestUpdated(kNamespace, kStatus, kId);
-  logger.RecordUpdateRequestFailed(kNamespace, kUpdateResult);
+  logger.RecordOfflinerResult(kNamespace, kOfflinerStatus, kId);
+  logger.RecordDroppedSavePageRequest(kNamespace, kDroppedResult, kId);
+  logger.RecordUpdateRequestFailed(kNamespace, kQueueUpdateResult);
   logger.GetLogs(&log);
 
-  EXPECT_EQ(2u, log.size());
-  EXPECT_EQ(std::string(kUpdateResultLogString), log[0].substr(kTimeLength));
-  EXPECT_EQ(std::string(kStatusLogString), log[1].substr(kTimeLength));
+  EXPECT_EQ(3u, log.size());
+  EXPECT_EQ(std::string(kQueueUpdateResultLogString),
+            log[0].substr(kTimeLength));
+  EXPECT_EQ(std::string(kDroppedResultLogString), log[1].substr(kTimeLength));
+  EXPECT_EQ(std::string(kOfflinerStatusLogString), log[2].substr(kTimeLength));
 }
 
 TEST(RequestCoordinatorEventLoggerTest, RecordsWhenLoggingIsOff) {
@@ -45,7 +50,7 @@ TEST(RequestCoordinatorEventLoggerTest, RecordsWhenLoggingIsOff) {
   std::vector<std::string> log;
 
   logger.SetIsLogging(false);
-  logger.RecordSavePageRequestUpdated(kNamespace, kStatus, kId);
+  logger.RecordOfflinerResult(kNamespace, kOfflinerStatus, kId);
   logger.GetLogs(&log);
 
   EXPECT_EQ(0u, log.size());
@@ -57,7 +62,7 @@ TEST(RequestCoordinatorEventLoggerTest, DoesNotExceedMaxSize) {
 
   logger.SetIsLogging(true);
   for (size_t i = 0; i < kMaxLogCount + 1; ++i) {
-    logger.RecordSavePageRequestUpdated(kNamespace, kStatus, kId);
+    logger.RecordOfflinerResult(kNamespace, kOfflinerStatus, kId);
   }
   logger.GetLogs(&log);