Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2324463006: Clean up warnings and hints (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -195 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_diagnostic.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_execution.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/uri_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/move_file.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/single_context_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/watch_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/single_context_manager_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/source/caching_put_package_map_provider_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 3 chunks +10 lines, -3 lines 2 comments Download
M pkg/analyzer/lib/source/analysis_options_provider.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/source/embedder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/source/package_map_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/source/pub_package_map_provider.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/source/sdk_ext.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/scope.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/bazel.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 7 chunks +155 lines, -155 lines 1 comment Download
M pkg/analyzer/lib/src/summary/incremental_cache.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/pub_summary.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/embedder_tests.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/file_system/memory_file_system_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/file_system/physical_resource_provider_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/resource_utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/source/analysis_options_provider_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/source/embedder_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/generate.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/lib/src/build_mode.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_cli/test/utils.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
https://codereview.chromium.org/2324463006/diff/1/pkg/analyzer/lib/src/generated/type_system.dart File pkg/analyzer/lib/src/generated/type_system.dart (left): https://codereview.chromium.org/2324463006/diff/1/pkg/analyzer/lib/src/generated/type_system.dart#oldcode19 pkg/analyzer/lib/src/generated/type_system.dart:19: show ErrorCode, ErrorReporter, StrongModeCode; This is the only change ...
4 years, 3 months ago (2016-09-09 15:52:03 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2324463006/diff/1/pkg/analyzer/lib/file_system/physical_file_system.dart File pkg/analyzer/lib/file_system/physical_file_system.dart (right): https://codereview.chromium.org/2324463006/diff/1/pkg/analyzer/lib/file_system/physical_file_system.dart#newcode47 pkg/analyzer/lib/file_system/physical_file_system.dart:47: typedef String FileReadMode(String s); Should this type be ...
4 years, 3 months ago (2016-09-09 15:56:49 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2324463006/diff/1/pkg/analyzer/lib/file_system/physical_file_system.dart File pkg/analyzer/lib/file_system/physical_file_system.dart (right): https://codereview.chromium.org/2324463006/diff/1/pkg/analyzer/lib/file_system/physical_file_system.dart#newcode47 pkg/analyzer/lib/file_system/physical_file_system.dart:47: typedef String FileReadMode(String s); I moved the typdef to ...
4 years, 3 months ago (2016-09-09 16:09:35 UTC) #4
Brian Wilkerson
4 years, 3 months ago (2016-09-09 16:10:03 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5bd4de469e0b60f55c758be22ce93b6c110c3ded (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698