Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: pkg/analyzer/lib/source/pub_package_map_provider.dart

Issue 2324463006: Clean up warnings and hints (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.source.pub_package_map_provider; 5 library analyzer.source.pub_package_map_provider;
6 6
7 import 'dart:collection'; 7 import 'dart:collection';
8 import 'dart:convert'; 8 import 'dart:convert';
9 import 'dart:core' hide Resource; 9 import 'dart:core';
10 import 'dart:io' as io; 10 import 'dart:io' as io;
11 11
12 import 'package:analyzer/file_system/file_system.dart'; 12 import 'package:analyzer/file_system/file_system.dart';
13 import 'package:analyzer/source/package_map_provider.dart'; 13 import 'package:analyzer/source/package_map_provider.dart';
14 import 'package:analyzer/src/dart/sdk/sdk.dart'; 14 import 'package:analyzer/src/dart/sdk/sdk.dart';
15 import 'package:analyzer/src/generated/engine.dart'; 15 import 'package:analyzer/src/generated/engine.dart';
16 16
17 /** 17 /**
18 * The function used to run pub list. 18 * The function used to run pub list.
19 */ 19 */
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 String workingDirectory = folder.path; 175 String workingDirectory = folder.path;
176 int subprocessId = AnalysisEngine.instance.instrumentationService 176 int subprocessId = AnalysisEngine.instance.instrumentationService
177 .logSubprocessStart(executablePath, arguments, workingDirectory); 177 .logSubprocessStart(executablePath, arguments, workingDirectory);
178 io.ProcessResult result = io.Process 178 io.ProcessResult result = io.Process
179 .runSync(executablePath, arguments, workingDirectory: workingDirectory); 179 .runSync(executablePath, arguments, workingDirectory: workingDirectory);
180 AnalysisEngine.instance.instrumentationService.logSubprocessResult( 180 AnalysisEngine.instance.instrumentationService.logSubprocessResult(
181 subprocessId, result.exitCode, result.stdout, result.stderr); 181 subprocessId, result.exitCode, result.stdout, result.stderr);
182 return result; 182 return result;
183 } 183 }
184 } 184 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698