Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2324253002: Revert of Remove calls to MessageLoop::current() in ios. (patchset #1 id:1 of https://codereview.ch… (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Revert of Remove calls to MessageLoop::current() in ios. (patchset #1 id:1 of https://codereview.chromium.org/2079423002/ ) Reason for revert: This causes crashes during browser startup. Original issue's description: > Remove calls to MessageLoop::current() in ios. > > Why? > The fact that there's a MessageLoop on the thread is an > unnecessary implementation detail. When browser threads > are migrated to base/task_scheduler, tasks will no longer > have access to a MessageLoop. > > These changes were generated manually. > > BUG=616447 > R=droger@chromium.org > > Committed: https://crrev.com/c5c127abb5f0d8ba0dd34cfbd6233bbf9209f0f2 > Cr-Commit-Position: refs/heads/master@{#401027} TBR=sdefresne@chromium.org BUG=616447, 634907 Review-Url: https://codereview.chromium.org/2326053002 Cr-Commit-Position: refs/heads/master@{#417583} (cherry picked from commit dce56180ec95f2609b67a40a28c284ef8025dd76) Committed: https://chromium.googlesource.com/chromium/src/+/b6cdd5581ab37389cdbed12ecc71d76e94b19f95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ios/web/web_thread_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
fdoray
Committed patchset #1 (id:1) manually as b6cdd5581ab37389cdbed12ecc71d76e94b19f95.
4 years, 3 months ago (2016-09-09 18:40:34 UTC) #2
sdefresne
4 years, 3 months ago (2016-09-12 08:14:47 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698