Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2326053002: Revert of Remove calls to MessageLoop::current() in ios. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, cbentzel+watch_chromium.org, justincohen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove calls to MessageLoop::current() in ios. (patchset #1 id:1 of https://codereview.chromium.org/2079423002/ ) Reason for revert: This causes crashes during browser startup. Original issue's description: > Remove calls to MessageLoop::current() in ios. > > Why? > The fact that there's a MessageLoop on the thread is an > unnecessary implementation detail. When browser threads > are migrated to base/task_scheduler, tasks will no longer > have access to a MessageLoop. > > These changes were generated manually. > > BUG=616447 > R=droger@chromium.org > > Committed: https://crrev.com/c5c127abb5f0d8ba0dd34cfbd6233bbf9209f0f2 > Cr-Commit-Position: refs/heads/master@{#401027} TBR=sdefresne@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=616447 Committed: https://crrev.com/dce56180ec95f2609b67a40a28c284ef8025dd76 Cr-Commit-Position: refs/heads/master@{#417583}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ios/web/web_thread_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
fdoray
Created Revert of Remove calls to MessageLoop::current() in ios.
4 years, 3 months ago (2016-09-09 14:00:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326053002/1
4 years, 3 months ago (2016-09-09 14:00:56 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/66591) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-09 14:02:25 UTC) #5
sdefresne
On 2016/09/09 14:02:25, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 3 months ago (2016-09-09 14:03:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326053002/70001
4 years, 3 months ago (2016-09-09 14:15:36 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:70001)
4 years, 3 months ago (2016-09-09 14:52:47 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 14:54:02 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dce56180ec95f2609b67a40a28c284ef8025dd76
Cr-Commit-Position: refs/heads/master@{#417583}

Powered by Google App Engine
This is Rietveld 408576698