Implement QuicHttpStream::GetLoadTimingInfo

net/quic/chromium/quic_chromium_client_stream.h

Index: net/quic/chromium/quic_chromium_client_stream.h
diff --git a/net/quic/chromium/quic_chromium_client_stream.h b/net/quic/chromium/quic_chromium_client_stream.h
index bef9eb4ebc90c52cb8f446f2e6b13f522cd430e5..d50c904ecd746dcac8ba686a993238f982588fb7 100644
--- a/net/quic/chromium/quic_chromium_client_stream.h
+++ b/net/quic/chromium/quic_chromium_client_stream.h
@@ -121,6 +121,10 @@ class NET_EXPORT_PRIVATE QuicChromiumClientStream : public QuicSpdyStream {
 
   bool can_migrate() { return can_migrate_; }
 
+  // Returns whether a stream with |id| is the first data stream created on a
+  // QUIC session.
+  static bool isFirstStream(QuicStreamId id);

[Ryan Hamilton, 2016/09/09 22:05:39]

Instead of making this a static method, let's make this non-static. In
QuicHttpStream, instead of stashing the stream_id, you'll want to stash the
result of calling this method.

[Ryan Hamilton, 2016/09/09 22:05:39]

I think this method should be "IsFirst", not "isFirst". "isFirst" is the
java-style and makes me miss java... *sniff*

[xunjieli, 2016/09/12 16:07:23]

If we only use a bool, there is no way to differentiate in QuicHttpStream
between when the QuicChromiumClientStream fails to be created and when the
QuicChromiumClientStream is not the first stream.

If we only have a |is_first_| bool in QuicHttpStream. Its default value is
false. If the stream failed for some reason, |is_first_| is false, and we will
return true in GetLoadTimingInfo.

In SpdyHttpStream, GetLoadTimingInfo returns false if the underlying spdy_stream
failed to be created. I stored the |id| to match the behavior. You can see the
diff of quic_http_stream_test.cc between PS #2 and PS #3 to see the change in
QuicHttpStream::GetLoadTimingInfo's behavior.

Maybe the difference is not significant, so I changed to use your approach.
Done. 

+
   using QuicSpdyStream::HasBufferedData;
 
  private: