Implement QuicHttpStream::GetLoadTimingInfo

net/quic/chromium/quic_chromium_client_stream.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // NOTE: This code is not shared between Google and Chrome.
 
 #ifndef NET_QUIC_QUIC_CHROMIUM_CLIENT_STREAM_H_
 #define NET_QUIC_QUIC_CHROMIUM_CLIENT_STREAM_H_
 
 #include <stddef.h>
@@ skipping 103 matching lines @@
   bool CanWrite(const CompletionCallback& callback);
 
   const BoundNetLog& net_log() const { return net_log_; }
 
   // Prevents this stream from migrating to a new network. May cause other
   // concurrent streams within the session to also not migrate.
   void DisableConnectionMigration();
 
   bool can_migrate() { return can_migrate_; }
 
+  // Returns whether a stream with |id| is the first data stream created on a
+  // QUIC session.
+  static bool isFirstStream(QuicStreamId id);

[Ryan Hamilton, 2016/09/09 22:05:39]

Instead of making this a static method, let's make this non-static. In
QuicHttpStream, instead of stashing the stream_id, you'll want to stash the
result of calling this method.

[Ryan Hamilton, 2016/09/09 22:05:39]

I think this method should be "IsFirst", not "isFirst". "isFirst" is the
java-style and makes me miss java... *sniff*

[xunjieli, 2016/09/12 16:07:23]

If we only use a bool, there is no way to differentiate in QuicHttpStream
between when the QuicChromiumClientStream fails to be created and when the
QuicChromiumClientStream is not the first stream.

If we only have a |is_first_| bool in QuicHttpStream. Its default value is
false. If the stream failed for some reason, |is_first_| is false, and we will
return true in GetLoadTimingInfo.

In SpdyHttpStream, GetLoadTimingInfo returns false if the underlying spdy_stream
failed to be created. I stored the |id| to match the behavior. You can see the
diff of quic_http_stream_test.cc between PS #2 and PS #3 to see the change in
QuicHttpStream::GetLoadTimingInfo's behavior.

Maybe the difference is not significant, so I changed to use your approach.
Done. 

+
   using QuicSpdyStream::HasBufferedData;
 
  private:
   void NotifyDelegateOfHeadersCompleteLater(SpdyHeaderBlock headers,
                                             size_t frame_len);
   void NotifyDelegateOfHeadersComplete(SpdyHeaderBlock headers,
                                        size_t frame_len);
   void NotifyDelegateOfDataAvailableLater();
   void NotifyDelegateOfDataAvailable();
   void RunOrBuffer(base::Closure closure);
@@ skipping 14 matching lines @@
   std::deque<base::Closure> delegate_tasks_;
 
   base::WeakPtrFactory<QuicChromiumClientStream> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicChromiumClientStream);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_CHROMIUM_CLIENT_STREAM_H_