Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2324133002: Replace GURL in BudgetDatabase/BudgetManager with url::Origin (Closed)

Created:
4 years, 3 months ago by harkness
Modified:
4 years, 3 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, Peter Beverloo, johnme+watch_chromium.org, harkness+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace GURL in BudgetDatabase/BudgetManager with url::Origin The Mojo service uses url::Origin, and that's the better way to be storing origins, so converting over to using that instead of GURL. This also does a bit of cleanup on the tests, which had a mix of methods which took an origin argument and methods which created the origin internally. Now the test has a member which is calculated once. BUG=617971 Committed: https://crrev.com/03be8a1d1c74c06fbe79b6cb79b879b50213b83a Cr-Commit-Position: refs/heads/master@{#417593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -108 lines) Patch
M chrome/browser/budget_service/budget_database.h View 6 chunks +19 lines, -15 lines 0 comments Download
M chrome/browser/budget_service/budget_database.cc View 17 chunks +32 lines, -35 lines 0 comments Download
M chrome/browser/budget_service/budget_database_unittest.cc View 15 chunks +28 lines, -30 lines 0 comments Download
M chrome/browser/budget_service/budget_manager.h View 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/budget_service/budget_manager.cc View 4 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/budget_service/budget_manager_unittest.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/budget_service/budget_service_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_notification_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
harkness
4 years, 3 months ago (2016-09-09 14:39:25 UTC) #2
Peter Beverloo
lgtm
4 years, 3 months ago (2016-09-09 14:50:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324133002/1
4 years, 3 months ago (2016-09-09 14:51:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 16:01:29 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 16:02:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03be8a1d1c74c06fbe79b6cb79b879b50213b83a
Cr-Commit-Position: refs/heads/master@{#417593}

Powered by Google App Engine
This is Rietveld 408576698