Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/browser/budget_service/budget_manager_unittest.cc

Issue 2324133002: Replace GURL in BudgetDatabase/BudgetManager with url::Origin (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/budget_service/budget_manager_unittest.cc
diff --git a/chrome/browser/budget_service/budget_manager_unittest.cc b/chrome/browser/budget_service/budget_manager_unittest.cc
index b670d8613fb4524747750a29cd3500dddcc4b2c9..c6af3b8c349cd39c2b29c675eba355a67b9d8092 100644
--- a/chrome/browser/budget_service/budget_manager_unittest.cc
+++ b/chrome/browser/budget_service/budget_manager_unittest.cc
@@ -17,6 +17,7 @@
#include "content/public/test/test_browser_thread_bundle.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/WebKit/public/platform/modules/budget_service/budget_service.mojom.h"
+#include "url/origin.h"
namespace {
@@ -27,18 +28,20 @@ const double kTestSES = 48.0;
class BudgetManagerTest : public testing::Test {
public:
+ BudgetManagerTest() : origin_(url::Origin(GURL(kTestOrigin))) {}
~BudgetManagerTest() override {}
BudgetManager* GetManager() {
return BudgetManagerFactory::GetForProfile(&profile_);
}
- void SetSiteEngagementScore(const GURL& url, double score) {
+ void SetSiteEngagementScore(double score) {
SiteEngagementService* service = SiteEngagementService::Get(&profile_);
- service->ResetScoreForURL(url, score);
+ service->ResetScoreForURL(GURL(kTestOrigin), score);
}
Profile* profile() { return &profile_; }
+ const url::Origin origin() const { return origin_; }
void StatusCallback(base::Closure run_loop_closure, bool success) {
success_ = success;
@@ -46,10 +49,9 @@ class BudgetManagerTest : public testing::Test {
}
bool ReserveBudget(blink::mojom::BudgetOperationType type) {
- const GURL origin(kTestOrigin);
base::RunLoop run_loop;
GetManager()->Reserve(
- origin, type,
+ origin(), type,
base::Bind(&BudgetManagerTest::StatusCallback, base::Unretained(this),
run_loop.QuitClosure()));
run_loop.Run();
@@ -57,10 +59,9 @@ class BudgetManagerTest : public testing::Test {
}
bool ConsumeBudget(blink::mojom::BudgetOperationType type) {
- const GURL origin(kTestOrigin);
base::RunLoop run_loop;
GetManager()->Consume(
- origin, type,
+ origin(), type,
base::Bind(&BudgetManagerTest::StatusCallback, base::Unretained(this),
run_loop.QuitClosure()));
run_loop.Run();
@@ -73,13 +74,13 @@ class BudgetManagerTest : public testing::Test {
private:
content::TestBrowserThreadBundle thread_bundle_;
TestingProfile profile_;
+ const url::Origin origin_;
};
TEST_F(BudgetManagerTest, GetBudgetConsumedOverTime) {
// Set initial SES. The first time we try to spend budget, the
// engagement award will be granted which is 48.0.
- const GURL origin(kTestOrigin);
- SetSiteEngagementScore(origin, kTestSES);
+ SetSiteEngagementScore(kTestSES);
const blink::mojom::BudgetOperationType type =
blink::mojom::BudgetOperationType::SILENT_PUSH;
« no previous file with comments | « chrome/browser/budget_service/budget_manager.cc ('k') | chrome/browser/budget_service/budget_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698