Remove use of NewTabPageAdapter.getItems() from test.

Remove use of NewTabPageAdapter.getItems() from test.

BUG=616090
Committed: https://crrev.com/abc11a38b69842f4cb51718a75d6701c48bbe954
Cr-Commit-Position: refs/heads/master@{#421500}

[Bernhard Bauer, 2016-09-09 10:25:45]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 10:26:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 11:35:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 11:35:08]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Bernhard Bauer, 2016-09-15 16:03:40]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 16:04:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 16:43:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 16:43:48]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-09-15 17:09:51]

bauerb@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[Bernhard Bauer, 2016-09-15 17:09:51]

Please review. Thanks!

[Michael van Ouwerkerk, 2016-09-16 09:47:13]

lgtm with nit

https://codereview.chromium.org/2324113003/diff/20001/chrome/android/junit/sr...
File
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
(right):

https://codereview.chromium.org/2324113003/diff/20001/chrome/android/junit/sr...
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java:544:
assertTrue(
I think you might want to use this matcher instead:
http://hamcrest.org/JavaHamcrest/javadoc/1.3/org/hamcrest/Matchers.html#great...

[Bernhard Bauer, 2016-09-16 13:46:38]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 13:47:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2016-09-16 13:55:29]

bauerb@chromium.org changed reviewers:
+ nyquist@chromium.org

[Bernhard Bauer, 2016-09-16 13:55:30]

Tommy, can I get an OWNERS review for base/test/android? Thanks!

https://codereview.chromium.org/2324113003/diff/20001/chrome/android/junit/sr...
File
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
(right):

https://codereview.chromium.org/2324113003/diff/20001/chrome/android/junit/sr...
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java:544:
assertTrue(
On 2016/09/16 09:47:13, Michael van Ouwerkerk wrote:
> I think you might want to use this matcher instead:
>
http://hamcrest.org/JavaHamcrest/javadoc/1.3/org/hamcrest/Matchers.html#great...

As discussed offline, these matchers are from hamcrest-library, which isn't
available to us right now (JUnit just happens to bundle hamcrest-core), so I've
built my own matcher.

[commit-bot: I haz the power, 2016-09-16 14:05:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 14:05:15]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nyquist, 2016-09-23 20:24:55]

base/test/android lgtm

[Bernhard Bauer, 2016-09-26 13:50:58]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 13:51:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 13:53:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 13:53:40]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Bernhard Bauer, 2016-09-26 14:16:37]

The CQ bit was checked by bauerb@chromium.org

[Bernhard Bauer, 2016-09-26 14:16:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvanouwerkerk@chromium.org, nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/2324113003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-26 14:16:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 14:32:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 14:32:12]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Bernhard Bauer, 2016-09-27 09:28:59]

The CQ bit was checked by bauerb@chromium.org

[Bernhard Bauer, 2016-09-27 09:28:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, mvanouwerkerk@chromium.org
Link to the patchset: https://codereview.chromium.org/2324113003/#ps100001
(title: "x")

[commit-bot: I haz the power, 2016-09-27 09:29:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 10:34:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 10:34:14]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Bernhard Bauer, 2016-09-28 09:46:56]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 09:47:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 10:33:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 10:33:03]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-09-28 12:17:05]

The CQ bit was checked by bauerb@chromium.org

[Bernhard Bauer, 2016-09-28 12:17:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, mvanouwerkerk@chromium.org
Link to the patchset: https://codereview.chromium.org/2324113003/#ps120001
(title: "fix?")

[commit-bot: I haz the power, 2016-09-28 12:17:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 12:22:06]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-28 12:23:50]

Description was changed from

==========
Remove use of NewTabPageAdapter.getItems() from test.

BUG=616090
==========

to

==========
Remove use of NewTabPageAdapter.getItems() from test.

BUG=616090

Committed: https://crrev.com/abc11a38b69842f4cb51718a75d6701c48bbe954
Cr-Commit-Position: refs/heads/master@{#421500}
==========

[commit-bot: I haz the power, 2016-09-28 12:23:52]

Patchset 7 (id:??) landed as
https://crrev.com/abc11a38b69842f4cb51718a75d6701c48bbe954
Cr-Commit-Position: refs/heads/master@{#421500}