Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Issue 2324113003: Remove use of NewTabPageAdapter.getItems() from test. (Closed)
Patch Set: fix? Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
index 886dd20d85d56b8cacb93fa8c6c2113e53588d80..3701ed4234429097581bd98fcae2f9a338c62d21 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
@@ -442,7 +442,7 @@ public class NewTabPageAdapter extends Adapter<NewTabPageViewHolder>
/**
* Returns an unmodifiable list containing all items in the adapter.
*/
- public List<NewTabPageItem> getItems() {
+ private List<NewTabPageItem> getItems() {
List<NewTabPageItem> items = new ArrayList<>();
for (ItemGroup group : mGroups) {
items.addAll(group.getItems());
@@ -466,7 +466,8 @@ public class NewTabPageAdapter extends Adapter<NewTabPageViewHolder>
return Collections.unmodifiableList(mGroups);
}
- private int getGroupPositionOffset(ItemGroup group) {
+ @VisibleForTesting
+ int getGroupPositionOffset(ItemGroup group) {
int positionOffset = 0;
for (ItemGroup candidateGroup : mGroups) {
if (candidateGroup == group) return positionOffset;
@@ -474,4 +475,9 @@ public class NewTabPageAdapter extends Adapter<NewTabPageViewHolder>
}
return RecyclerView.NO_POSITION;
}
+
+ @VisibleForTesting
+ SnippetArticle getSuggestionAt(int position) {
+ return (SnippetArticle) getItems().get(position);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698