Source/core/rendering/style/RenderStyle.cpp - Issue 23241010: Support subpixel values for text-shadow and box-shadow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/style/RenderStyle.cpp

Issue 23241010: Support subpixel values for text-shadow and box-shadow (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: missed a virtual test Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/RenderBoxModelObject.cpp ('K') | « Source/core/rendering/RenderBoxModelObject.cpp ('k') | Source/core/rendering/style/ShadowData.h » ('j') | Source/core/rendering/style/ShadowList.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/style/RenderStyle.cpp

diff --git a/Source/core/rendering/style/RenderStyle.cpp b/Source/core/rendering/style/RenderStyle.cpp

index 4c137d4ae3278ebc8559faf45b689470a0aadf6e..e892bd5576eb2f5930da94eef23195edd40a9de6 100644

--- a/Source/core/rendering/style/RenderStyle.cpp

+++ b/Source/core/rendering/style/RenderStyle.cpp

@@ -1275,7 +1275,7 @@ void RenderStyle::getShadowExtent(const ShadowList* shadowList, LayoutUnit &top,

const ShadowData& shadow = shadowList->shadows()[i];

if (shadow.style() == Inset)

continue;

- int blurAndSpread = shadow.blur() + shadow.spread();

+ float blurAndSpread = shadow.blur() + shadow.spread();

top = min<LayoutUnit>(top, shadow.y() - blurAndSpread);

right = max<LayoutUnit>(right, shadow.x() + blurAndSpread);

@@ -1296,7 +1296,7 @@ LayoutBoxExtent RenderStyle::getShadowInsetExtent(const ShadowList* shadowList)

const ShadowData& shadow = shadowList->shadows()[i];

if (shadow.style() == Normal)

continue;

- int blurAndSpread = shadow.blur() + shadow.spread();

+ float blurAndSpread = shadow.blur() + shadow.spread();

top = max<LayoutUnit>(top, shadow.y() + blurAndSpread);

right = min<LayoutUnit>(right, shadow.x() - blurAndSpread);

bottom = min<LayoutUnit>(bottom, shadow.y() - blurAndSpread);

@@ -1316,7 +1316,7 @@ void RenderStyle::getShadowHorizontalExtent(const ShadowList* shadowList, Layout

const ShadowData& shadow = shadowList->shadows()[i];

if (shadow.style() == Inset)

continue;

- int blurAndSpread = shadow.blur() + shadow.spread();

+ float blurAndSpread = shadow.blur() + shadow.spread();

left = min<LayoutUnit>(left, shadow.x() - blurAndSpread);

right = max<LayoutUnit>(right, shadow.x() + blurAndSpread);

@@ -1333,7 +1333,7 @@ void RenderStyle::getShadowVerticalExtent(const ShadowList* shadowList, LayoutUn

const ShadowData& shadow = shadowList->shadows()[i];

if (shadow.style() == Inset)

continue;

- int blurAndSpread = shadow.blur() + shadow.spread();

+ float blurAndSpread = shadow.blur() + shadow.spread();

top = min<LayoutUnit>(top, shadow.y() - blurAndSpread);

bottom = max<LayoutUnit>(bottom, shadow.y() + blurAndSpread);