Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2324083002: Added ASSERT_SIZE checks to CSSValueList and CSSPrimitiveValue (Closed)

Created:
4 years, 3 months ago by sashab
Modified:
4 years, 3 months ago
Reviewers:
meade_UTC10, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added ASSERT_SIZE checks to CSSValueList and CSSPrimitiveValue BUG=486252 Committed: https://crrev.com/d800ef405a871e329e0ccea60db244705a5ed8f2 Cr-Commit-Position: refs/heads/master@{#419671}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Changed void* to double in SameSizeAs check for PrimitiveValue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueList.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (15 generated)
sashab
4 years, 3 months ago (2016-09-09 01:43:30 UTC) #2
sashab
Eddy: for context, see dependent patchset :) Also just fyi this is prereq work for ...
4 years, 3 months ago (2016-09-09 01:44:11 UTC) #3
meade_UTC10
lgtm
4 years, 3 months ago (2016-09-12 01:30:35 UTC) #4
rune
lgtm
4 years, 3 months ago (2016-09-12 08:57:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324083002/1
4 years, 3 months ago (2016-09-15 00:05:08 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/128835) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-09-15 00:15:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324083002/40001
4 years, 3 months ago (2016-09-20 03:39:28 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-20 03:45:13 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 03:49:25 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d800ef405a871e329e0ccea60db244705a5ed8f2
Cr-Commit-Position: refs/heads/master@{#419671}

Powered by Google App Engine
This is Rietveld 408576698