Removed parent data storage common to multiple CSSValues

Removed parent data storage common to multiple CSSValues

Removed parent data storage common to multiple CSSValues, such as
CSSValueList type bits and CSSPrimitiveValue type bits. This has no
effect on sizeof(CSSPrimitiveValue) (which remains at 4 bytes) or
sizeof(CSSValueList) (which remains at 56 bytes).

BUG=486252

[sashab, 2016-08-11 04:29:20]

sashab@chromium.org changed reviewers:
+ esprehn@chromium.org, timloh@chromium.org

[sashab, 2016-08-11 04:29:20]

Esprehn/timloh any idea why this was done this way?

[esprehn, 2016-08-11 05:42:35]

Are there static_asserts about the sizes for this? This was done so the bits can
all pack together, I don't think all compilers will pack stuff from the super
class with stuff from the subclasses.

https://codereview.chromium.org/2232093002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSValue.h (left):

https://codereview.chromium.org/2232093002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSValue.h:210: unsigned m_valueListSeparator
: ValueListSeparatorBits;
this was done so these bits can pack with m_classType

[sashab, 2016-08-18 05:21:36]

Description was changed from

==========
Removed parent data storage common to multiple CSSValues

Removed parent data storage common to multiple CSSValues, such as
CSSValueList type bits and CSSPrimitiveValue type bits. This has no
effect on sizeof(CSSValue) (which remains at 4 bytes) or
sizeof(CSSValueList) (which remains at 56 bytes).

BUG=486252
==========

to

==========
Removed parent data storage common to multiple CSSValues

Removed parent data storage common to multiple CSSValues, such as
CSSValueList type bits and CSSPrimitiveValue type bits. This has no
effect on sizeof(CSSPrimitiveValue) (which remains at 4 bytes) or
sizeof(CSSValueList) (which remains at 56 bytes).

BUG=486252
==========

[sashab, 2016-08-18 05:43:59]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 05:44:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 05:59:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 05:59:27]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[sashab, 2016-09-23 01:44:41]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 01:45:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 02:51:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 02:51:48]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[sashab, 2016-09-23 02:54:27]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 02:54:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 03:06:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 03:06:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sashab, 2016-09-30 03:20:22]

You're right. Thanks to those static_asserts we can see, this does indeed make
the classes bigger. :)