chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h - Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h

Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions. (Closed)

Patch Set: Less explosions Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc ('K') | « chrome/browser/extensions/api/preference/preference_api.cc ('k') | chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc » ('j') | chrome/browser/extensions/api/tabs/tabs_event_router.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h

diff --git a/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h b/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h

index ee2ff05181839d3e880ee67bc75ab5a79384feda..b08d043a08753c134195929c6fa11a278063bddf 100644

--- a/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h

+++ b/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h

@@ -5,6 +5,7 @@

#ifndef CHROME_BROWSER_EXTENSIONS_API_SCREENLOCK_PRIVATE_SCREENLOCK_PRIVATE_API_H_

#define CHROME_BROWSER_EXTENSIONS_API_SCREENLOCK_PRIVATE_SCREENLOCK_PRIVATE_API_H_

+#include <memory>

#include <string>

#include "base/macros.h"

@@ -88,7 +89,7 @@ class ScreenlockPrivateEventRouter

void DispatchEvent(events::HistogramValue histogram_value,

const std::string& event_name,

- base::Value* arg);

+ std::unique_ptr<base::Value> arg);

content::BrowserContext* browser_context_;

DISALLOW_COPY_AND_ASSIGN(ScreenlockPrivateEventRouter);