Clarify a role of Shadow DOM related functions

third_party/WebKit/Source/core/dom/shadow/ElementShadow.h

Index: third_party/WebKit/Source/core/dom/shadow/ElementShadow.h
diff --git a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.h b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.h
index 95b935dde01cac2aa767d47e872bfa575a98d600..3dc877ccc37f6ba8d32b4e9d9393efe8a158431a 100644
--- a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.h
+++ b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.h
@@ -55,21 +55,22 @@ public:
     void attach(const Node::AttachContext&);
     void detach(const Node::AttachContext&);
 
-    void willAffectSelector();
-    const SelectRuleFeatureSet& ensureSelectFeatureSet();
-
     void distributeIfNeeded();
     void setNeedsDistributionRecalc();
     bool needsDistributionRecalc() const { return m_needsDistributionRecalc; }
 
+    bool isV1() const { return youngestShadowRoot().isV1(); };
+    bool isOpenOrV0() const { return youngestShadowRoot().isOpenOrV0(); };
+
+    // For only v0
+    void willAffectSelector();
+    const SelectRuleFeatureSet& ensureSelectFeatureSet();
+
     const InsertionPoint* finalDestinationInsertionPointFor(const Node*) const;
     const DestinationInsertionPoints* destinationInsertionPointsFor(const Node*) const;
 
     void didDistributeNode(const Node*, InsertionPoint*);
 

[kochi, 2016/09/09 06:51:06]

nit: Why not adding "V0" or "ForV0" for these functions?

[hayato, 2016/09/09 07:03:28]

I won't it now. That can be considered at further refactoring.

-    bool isV1() const { return youngestShadowRoot().isV1(); };
-    bool isOpenOrV0() const { return youngestShadowRoot().isOpenOrV0(); };
-
     DECLARE_TRACE();
     DECLARE_TRACE_WRAPPERS();
 
@@ -79,7 +80,7 @@ private:
     void appendShadowRoot(ShadowRoot&);
 
     void distribute();
-    void clearDistribution();
+    void clearDistributionV0();
 
     void distributeV0();
     void distributeV1();
@@ -90,12 +91,13 @@ private:
     bool needsSelectFeatureSet() const { return m_needsSelectFeatureSet; }
     void setNeedsSelectFeatureSet() { m_needsSelectFeatureSet = true; }
 
+    Member<ShadowRoot> m_shadowRoot;
+    bool m_needsDistributionRecalc;
+
+    // For only v0
     using NodeToDestinationInsertionPoints = HeapHashMap<Member<const Node>, Member<DestinationInsertionPoints>>;
     NodeToDestinationInsertionPoints m_nodeToInsertionPoints;
-
     SelectRuleFeatureSet m_selectFeatures;
-    Member<ShadowRoot> m_shadowRoot;
-    bool m_needsDistributionRecalc;
     bool m_needsSelectFeatureSet;
 };