Disallow users modify canvas after it transfers control to offscreen

Disallow users modify canvas after it transfers control to offscreen

After a canvas has transferred its control to Offscreen, we should not allow
users to perform resizing, toDataURL, toBlob and getContext.

This is a reland of
https://crrev.com/85264448db0298f836e6d7bf95ad11134637e4ed
at refs/heads/master@{#418114}.

BUG=563852
Committed: https://crrev.com/3e197101b919d7fd7d64fbebabaaefc0c1f68344
Cr-Commit-Position: refs/heads/master@{#418357}

[xlai (Olivia), 2016-09-09 20:00:05]

Patchset #1 (id:1) has been deleted

[xlai (Olivia), 2016-09-09 20:21:14]

xlai@chromium.org changed reviewers:
+ junov@chromium.org

[Justin Novosad, 2016-09-12 19:40:40]

On 2016/09/09 20:21:15, xlai (Olivia) wrote:

lgtm

[xlai (Olivia), 2016-09-12 20:42:04]

The CQ bit was checked by xlai@chromium.org

[xlai (Olivia), 2016-09-12 20:42:04]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2323933004/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-12 20:42:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 00:13:39]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-13 00:17:37]

Description was changed from

==========
Disallow users modify canvas after it transfers control to offscreen

After a canvas has transferred its control to Offscreen, we should not allow
users to perform resizing, toDataURL, toBlob and getContext.

BUG=563852
==========

to

==========
Disallow users modify canvas after it transfers control to offscreen

After a canvas has transferred its control to Offscreen, we should not allow
users to perform resizing, toDataURL, toBlob and getContext.

BUG=563852

Committed: https://crrev.com/85264448db0298f836e6d7bf95ad11134637e4ed
Cr-Commit-Position: refs/heads/master@{#418114}
==========

[commit-bot: I haz the power, 2016-09-13 00:17:38]

Patchset 3 (id:??) landed as
https://crrev.com/85264448db0298f836e6d7bf95ad11134637e4ed
Cr-Commit-Position: refs/heads/master@{#418114}

[kjellander_chromium, 2016-09-13 07:42:18]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2335903003/ by kjellander@chromium.org.

The reason for reverting is: Breaks webkit_tests consistently after submit:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...

.

[Justin Novosad, 2016-09-13 15:00:11]

https://codereview.chromium.org/2323933004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (right):

https://codereview.chromium.org/2323933004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:666:
exceptionState.throwDOMException(InvalidStateError, "canvas.toDataURL is not
allowed for a canvas that has transferred its control to offscreen.");
No idea if this is what is causing the leak, but you need to return here.

https://codereview.chromium.org/2323933004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:715:
exceptionState.throwDOMException(InvalidStateError, "canvas.toBlob is not
allowed for a canvas that has transferred its control to offscreen.");
You need to return here

[xlai (Olivia), 2016-09-13 17:21:53]

Description was changed from

==========
Disallow users modify canvas after it transfers control to offscreen

After a canvas has transferred its control to Offscreen, we should not allow
users to perform resizing, toDataURL, toBlob and getContext.

BUG=563852

Committed: https://crrev.com/85264448db0298f836e6d7bf95ad11134637e4ed
Cr-Commit-Position: refs/heads/master@{#418114}
==========

to

==========
Disallow users modify canvas after it transfers control to offscreen

After a canvas has transferred its control to Offscreen, we should not allow
users to perform resizing, toDataURL, toBlob and getContext.

BUG=563852

Committed: https://crrev.com/85264448db0298f836e6d7bf95ad11134637e4ed
Cr-Commit-Position: refs/heads/master@{#418114}
==========

[xlai (Olivia), 2016-09-13 17:55:40]

Description was changed from

==========
Disallow users modify canvas after it transfers control to offscreen

After a canvas has transferred its control to Offscreen, we should not allow
users to perform resizing, toDataURL, toBlob and getContext.

BUG=563852

Committed: https://crrev.com/85264448db0298f836e6d7bf95ad11134637e4ed
Cr-Commit-Position: refs/heads/master@{#418114}
==========

to

==========
Disallow users modify canvas after it transfers control to offscreen

After a canvas has transferred its control to Offscreen, we should not allow
users to perform resizing, toDataURL, toBlob and getContext.

This is a reland of
https://crrev.com/85264448db0298f836e6d7bf95ad11134637e4ed
at refs/heads/master@{#418114}.


BUG=563852
==========

[xlai (Olivia), 2016-09-13 18:28:26]

The CQ bit was checked by xlai@chromium.org

[xlai (Olivia), 2016-09-13 18:28:27]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2323933004/#ps100001
(title: "Fix")

[commit-bot: I haz the power, 2016-09-13 18:29:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 20:44:14]

Description was changed from

==========
Disallow users modify canvas after it transfers control to offscreen

After a canvas has transferred its control to Offscreen, we should not allow
users to perform resizing, toDataURL, toBlob and getContext.

This is a reland of
https://crrev.com/85264448db0298f836e6d7bf95ad11134637e4ed
at refs/heads/master@{#418114}.


BUG=563852
==========

to

==========
Disallow users modify canvas after it transfers control to offscreen

After a canvas has transferred its control to Offscreen, we should not allow
users to perform resizing, toDataURL, toBlob and getContext.

This is a reland of
https://crrev.com/85264448db0298f836e6d7bf95ad11134637e4ed
at refs/heads/master@{#418114}.


BUG=563852
==========

[commit-bot: I haz the power, 2016-09-13 20:44:15]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-09-13 20:47:34]

Description was changed from

==========
Disallow users modify canvas after it transfers control to offscreen

After a canvas has transferred its control to Offscreen, we should not allow
users to perform resizing, toDataURL, toBlob and getContext.

This is a reland of
https://crrev.com/85264448db0298f836e6d7bf95ad11134637e4ed
at refs/heads/master@{#418114}.


BUG=563852
==========

to

==========
Disallow users modify canvas after it transfers control to offscreen

After a canvas has transferred its control to Offscreen, we should not allow
users to perform resizing, toDataURL, toBlob and getContext.

This is a reland of
https://crrev.com/85264448db0298f836e6d7bf95ad11134637e4ed
at refs/heads/master@{#418114}.

BUG=563852

Committed: https://crrev.com/3e197101b919d7fd7d64fbebabaaefc0c1f68344
Cr-Commit-Position: refs/heads/master@{#418357}
==========

[commit-bot: I haz the power, 2016-09-13 20:47:36]

Patchset 5 (id:??) landed as
https://crrev.com/3e197101b919d7fd7d64fbebabaaefc0c1f68344
Cr-Commit-Position: refs/heads/master@{#418357}