third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp - Issue 2323933004: Disallow users modify canvas after it transfers control to offscreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

Issue 2323933004: Disallow users modify canvas after it transfers control to offscreen (Closed)

Patch Set: Fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

index fe87277d0b3ee6d1931c8557cc73aaccb368f664..3d3f0736e97da17a970bbcde7ef9000ce9273ee2 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

@@ -679,8 +679,7 @@ TEST_F(CanvasRenderingContext2DTest, ImageResourceLifetime)

Element* canvasElement = document().createElement("canvas", nonThrowableExceptionState);

EXPECT_FALSE(nonThrowableExceptionState.hadException());

HTMLCanvasElement* canvas = static_cast<HTMLCanvasElement*>(canvasElement);

- canvas->setHeight(40);

- canvas->setWidth(40);

+ canvas->setSize(IntSize(40, 40));

ImageBitmap* imageBitmapDerived = nullptr;

{

const ImageBitmapOptions defaultOptions;

« no previous file with comments | « third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.idl ('k') | no next file » | no next file with comments »