Stop using the Keychain for passwords finally and clean up the Chrome entries there.

Stop using the Keychain for passwords finally and clean up the Chrome entries there.

Design doc: https://docs.google.com/a/google.com/document/d/1dZEBkuRqW_I8KqAYbo5-RpJxSOx7JGoslmgBVzqr98A/edit?usp=sharing

BUG=466638
Committed: https://crrev.com/a1600bfcbef4ee302d6ef4be1437fe97d580a6cf
Cr-Commit-Position: refs/heads/master@{#418286}

[vasilii, 2016-09-08 18:53:45]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 18:54:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vasilii, 2016-09-08 18:56:53]

vasilii@chromium.org changed reviewers:
+ isherman@chromium.org, vabr@chromium.org

[vasilii, 2016-09-08 18:56:53]

Hi all,

please review:

vabr@: everything
isherman@: histograms.xml

[commit-bot: I haz the power, 2016-09-08 20:20:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 20:20:37]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-09-08 20:31:09]

histograms.xml lgtm

[vabr (Chromium), 2016-09-09 10:09:44]

LGTM, thanks for your tireless work on this migration, Vasilii!

Vaclav

https://codereview.chromium.org/2323893002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/password_store_mac.h (right):

https://codereview.chromium.org/2323893002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/password_store_mac.h:40: MIGRATION_PARTIAL,
nit: This new value deserves a comment. Unlike for the others, for "partial" it
is not clear what it means.

[vasilii, 2016-09-09 10:27:02]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 10:27:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vasilii, 2016-09-09 10:27:57]

I'm waiting in case somebody speaks up against landing the CL.

https://codereview.chromium.org/2323893002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/password_store_mac.h (right):

https://codereview.chromium.org/2323893002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/password_store_mac.h:40: MIGRATION_PARTIAL,
On 2016/09/09 10:09:44, vabr (Chromium) wrote:
> nit: This new value deserves a comment. Unlike for the others, for "partial"
it
> is not clear what it means.

Done.

[commit-bot: I haz the power, 2016-09-09 11:36:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 11:36:33]

Dry run: This issue passed the CQ dry run.

[vasilii, 2016-09-13 16:21:35]

The CQ bit was checked by vasilii@chromium.org

[vasilii, 2016-09-13 16:21:35]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2323893002/#ps20001
(title: "add a comment")

[commit-bot: I haz the power, 2016-09-13 16:22:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 17:40:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-13 17:42:04]

Description was changed from

==========
Stop using the Keychain for passwords finally and clean up the Chrome entries
there.

Design doc:
https://docs.google.com/a/google.com/document/d/1dZEBkuRqW_I8KqAYbo5-RpJxSOx7...

BUG=466638
==========

to

==========
Stop using the Keychain for passwords finally and clean up the Chrome entries
there.

Design doc:
https://docs.google.com/a/google.com/document/d/1dZEBkuRqW_I8KqAYbo5-RpJxSOx7...

BUG=466638

Committed: https://crrev.com/a1600bfcbef4ee302d6ef4be1437fe97d580a6cf
Cr-Commit-Position: refs/heads/master@{#418286}
==========

[commit-bot: I haz the power, 2016-09-13 17:42:06]

Patchset 2 (id:??) landed as
https://crrev.com/a1600bfcbef4ee302d6ef4be1437fe97d580a6cf
Cr-Commit-Position: refs/heads/master@{#418286}