components/password_manager/core/browser/keychain_migration_status_mac.h - Issue 2323893002: Stop using the Keychain for passwords finally and clean up the Chrome entries there.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/keychain_migration_status_mac.h

Issue 2323893002: Stop using the Keychain for passwords finally and clean up the Chrome entries there. (Closed)

Patch Set: add a comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_proxy_mac_unittest.cc ('k') | components/password_manager/core/browser/password_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/keychain_migration_status_mac.h

diff --git a/components/password_manager/core/browser/keychain_migration_status_mac.h b/components/password_manager/core/browser/keychain_migration_status_mac.h

index 23c2b18e2f67720f81aeb272e82ab3e8f5414c5c..70f25f246c64958620d154f097cb25433c65c0af 100644

--- a/components/password_manager/core/browser/keychain_migration_status_mac.h

+++ b/components/password_manager/core/browser/keychain_migration_status_mac.h

@@ -23,6 +23,12 @@ enum class MigrationStatus {

// Migration failed twice. It should not be tried again.

FAILED_TWICE,

+ // Migration finished successfully. The Keychain was cleaned up.

+ MIGRATED_DELETED,

+ // Best effort migration happened. Some passwords were inaccessible.

+ MIGRATED_PARTIALLY,

MIGRATION_STATUS_COUNT,

};