Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2323833002: GN: add a helper script for running Android builds (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: add a helper script for running Android builds Think of this as the spiritual equivalent of platform_tools/android/bin/android_run_skia, but for GN and easier to type. Cutting down the debug symbols makes Android builds about 1/4 the size. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323833002 DOCS_PREVIEW= https://skia.org/user/quick/gn?cl=2323833002 Committed: https://skia.googlesource.com/skia/+/f3155ad97c8095e5172fb826d7f09b7a85062f25

Patch Set 1 #

Patch Set 2 : docs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
A bin/droid View 1 1 chunk +20 lines, -0 lines 0 comments Download
M gn/BUILD.gn View 2 chunks +8 lines, -1 line 0 comments Download
M site/user/quick/gn.md View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
mtklein_C
4 years, 3 months ago (2016-09-08 16:41:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323833002/20001
4 years, 3 months ago (2016-09-08 16:42:07 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-08 16:42:09 UTC) #10
jcgregorio
lgtm
4 years, 3 months ago (2016-09-08 17:02:47 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 17:03:24 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f3155ad97c8095e5172fb826d7f09b7a85062f25

Powered by Google App Engine
This is Rietveld 408576698