Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: gn/BUILD.gn

Issue 2323833002: GN: add a helper script for running Android builds (Closed)
Patch Set: docs Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « bin/droid ('k') | site/user/quick/gn.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gn/BUILD.gn
diff --git a/gn/BUILD.gn b/gn/BUILD.gn
index c5db0a96608b0760588e559d24a6a44ac4182f09..fd2d0074c6f9abadeccf65b71206b99fa2147560 100644
--- a/gn/BUILD.gn
+++ b/gn/BUILD.gn
@@ -31,7 +31,6 @@ config("no_rtti") {
config("default") {
cflags = [
"-O1",
- "-g",
"-fstrict-aliasing",
"-fPIC",
"-fvisibility=hidden",
@@ -57,6 +56,14 @@ config("default") {
]
ldflags = []
+ # It's annoying to wait for full debug symbols to push over
+ # to Android devices. -gline-tables-only is a lot slimmer.
+ if (is_android) {
+ cflags += [ "-gline-tables-only" ]
+ } else {
+ cflags += [ "-g" ]
+ }
+
if (current_cpu == "arm") {
cflags += [
"-march=armv7-a",
« no previous file with comments | « bin/droid ('k') | site/user/quick/gn.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698