Add tests for dismissing/denying push permission prompt on Android

Add tests for dismissing/denying push permission prompt on Android

BUG=644050
Committed: https://crrev.com/efdf980d6049586a6860e36edd44729ccf76996a
Cr-Commit-Position: refs/heads/master@{#417345}

[johnme, 2016-09-08 13:23:11]

Description was changed from

==========
Add test for dismissing/denying push permission prompt on Android

BUG=644050
==========

to

==========
Add tests for dismissing/denying push permission prompt on Android

BUG=644050
==========

[johnme, 2016-09-08 13:48:21]

johnme@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2016-09-08 14:38:32]

lgtm

Does it make sense to add a similar instrumentation test for notifications too?

https://codereview.chromium.org/2323753002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java
(right):

https://codereview.chromium.org/2323753002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java:88:
* Verifies that PushManager.subscribe() fails if Notifications permission was
already denied.
"Notifications permission" reads weird, it feels to me like that should be
singular?

https://codereview.chromium.org/2323753002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java:93:
loadUrl(mPushTestPage);
Can we move this call to setUp()? It's duplicated in each test.

[johnme, 2016-09-08 16:48:51]

> Does it make sense to add a similar instrumentation test for notifications
too?

Done: https://codereview.chromium.org/2316303004

https://codereview.chromium.org/2323753002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java
(right):

https://codereview.chromium.org/2323753002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java:88:
* Verifies that PushManager.subscribe() fails if Notifications permission was
already denied.
On 2016/09/08 14:38:32, Peter Beverloo wrote:
> "Notifications permission" reads weird, it feels to me like that should be
> singular?

It's fairly consistently called Notifications when talking about the permission.
Both in the code (PERMISSION_NOTIFICATIONS, CONTENT_SETTINGS_TYPE_NOTIFICATIONS,
PREF_NOTIFICATIONS_PERMISSION, ...) and in the UI (the Origin Info Bubble lists
is as "Notifications").

https://codereview.chromium.org/2323753002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java:93:
loadUrl(mPushTestPage);
On 2016/09/08 14:38:32, Peter Beverloo wrote:
> Can we move this call to setUp()? It's duplicated in each test.

Done.

[johnme, 2016-09-08 17:26:29]

The CQ bit was checked by johnme@chromium.org

[johnme, 2016-09-08 17:26:30]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2323753002/#ps40001
(title: "Move loadUrl to setUp")

[commit-bot: I haz the power, 2016-09-08 17:27:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 18:26:42]

Description was changed from

==========
Add tests for dismissing/denying push permission prompt on Android

BUG=644050
==========

to

==========
Add tests for dismissing/denying push permission prompt on Android

BUG=644050
==========

[commit-bot: I haz the power, 2016-09-08 18:26:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-08 18:30:15]

Description was changed from

==========
Add tests for dismissing/denying push permission prompt on Android

BUG=644050
==========

to

==========
Add tests for dismissing/denying push permission prompt on Android

BUG=644050

Committed: https://crrev.com/efdf980d6049586a6860e36edd44729ccf76996a
Cr-Commit-Position: refs/heads/master@{#417345}
==========

[commit-bot: I haz the power, 2016-09-08 18:30:16]

Patchset 3 (id:??) landed as
https://crrev.com/efdf980d6049586a6860e36edd44729ccf76996a
Cr-Commit-Position: refs/heads/master@{#417345}