Add tests for notifications infobar on Android

Add tests for notifications infobar on Android

BUG=644050
Committed: https://crrev.com/8569349a2517d5429a716a0fc78c609f34d2c815
Cr-Commit-Position: refs/heads/master@{#417369}

[johnme, 2016-09-08 16:49:12]

johnme@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2016-09-08 17:26:01]

lgtm

https://codereview.chromium.org/2316303004/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java
(right):

https://codereview.chromium.org/2316303004/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java:99:
@MediumTest
@LargeTest? Seems appropriate given the number of things it does.

https://codereview.chromium.org/2316303004/diff/1/chrome/test/data/notificati...
File chrome/test/data/notifications/android_test.html (right):

https://codereview.chromium.org/2316303004/diff/1/chrome/test/data/notificati...
chrome/test/data/notifications/android_test.html:20: // TODO(mvanouwerkerk): Use
DomAutomationController - crbug.com/562487
Delete, I don't think this is particularly useful, especially not on Michael's
name. (Especially since we know that implementing DAC for instrumentation tests
is infeasible.)

[johnme, 2016-09-08 18:34:37]

Addressed review nits - thanks :)

https://codereview.chromium.org/2316303004/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java
(right):

https://codereview.chromium.org/2316303004/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java:99:
@MediumTest
On 2016/09/08 17:26:01, Peter Beverloo wrote:
> @LargeTest? Seems appropriate given the number of things it does.

Done.

https://codereview.chromium.org/2316303004/diff/1/chrome/test/data/notificati...
File chrome/test/data/notifications/android_test.html (right):

https://codereview.chromium.org/2316303004/diff/1/chrome/test/data/notificati...
chrome/test/data/notifications/android_test.html:20: // TODO(mvanouwerkerk): Use
DomAutomationController - crbug.com/562487
On 2016/09/08 17:26:01, Peter Beverloo wrote:
> Delete, I don't think this is particularly useful, especially not on Michael's
> name. (Especially since we know that implementing DAC for instrumentation
tests
> is infeasible.)

Done.

[johnme, 2016-09-08 18:34:42]

The CQ bit was checked by johnme@chromium.org

[johnme, 2016-09-08 18:34:43]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2316303004/#ps20001
(title: "Review nits")

[commit-bot: I haz the power, 2016-09-08 18:35:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 19:52:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-08 19:56:36]

Description was changed from

==========
Add tests for notifications infobar on Android

BUG=644050
==========

to

==========
Add tests for notifications infobar on Android

BUG=644050

Committed: https://crrev.com/8569349a2517d5429a716a0fc78c609f34d2c815
Cr-Commit-Position: refs/heads/master@{#417369}
==========

[commit-bot: I haz the power, 2016-09-08 19:56:37]

Patchset 2 (id:??) landed as
https://crrev.com/8569349a2517d5429a716a0fc78c609f34d2c815
Cr-Commit-Position: refs/heads/master@{#417369}