Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2323733002: Compute ResolutionImpact directly from kernel, part 1 of ? (Closed)

Created:
4 years, 3 months ago by Johnni Winther
Modified:
4 years, 3 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compute ResolutionImpact directly from kernel, part 1 of ? R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/8bdf7ab425766541c8eb56b8bf2bffe51384fb72

Patch Set 1 #

Patch Set 2 : dartfmt #

Total comments: 1

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -65 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 1 6 chunks +7 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/kernel/accessors.dart View 1 4 chunks +5 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 2 7 chunks +16 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 6 chunks +61 lines, -8 lines 0 comments Download
A pkg/compiler/lib/src/ssa/kernel_impact.dart View 1 2 1 chunk +203 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/kernel/impact_test.dart View 1 chunk +101 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 3 months ago (2016-09-08 11:58:47 UTC) #2
Harry Terkelsen
lgtm https://codereview.chromium.org/2323733002/diff/20001/pkg/compiler/lib/src/resolution/registry.dart File pkg/compiler/lib/src/resolution/registry.dart (right): https://codereview.chromium.org/2323733002/diff/20001/pkg/compiler/lib/src/resolution/registry.dart#newcode161 pkg/compiler/lib/src/resolution/registry.dart:161: final ResolutionWorldImpactBuilder worldImpact; also change variable name to ...
4 years, 3 months ago (2016-09-08 16:46:28 UTC) #3
Johnni Winther
4 years, 3 months ago (2016-09-09 07:24:55 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
8bdf7ab425766541c8eb56b8bf2bffe51384fb72 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698