pkg/compiler/lib/src/resolution/members.dart - Issue 2323733002: Compute ResolutionImpact directly from kernel, part 1 of ?

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/resolution/members.dart

Issue 2323733002: Compute ResolutionImpact directly from kernel, part 1 of ? (Closed)

Patch Set: Updated cf. comments. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/resolution/members.dart

diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart

index efc6e0da4f5c9bd4f9d503a6de9b6a722a586e60..14c1aab6aa0faf0cd28f1e984a8d103f96f416fd 100644

--- a/pkg/compiler/lib/src/resolution/members.dart

+++ b/pkg/compiler/lib/src/resolution/members.dart

@@ -4061,7 +4061,9 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {

DartType type = typeResolver.resolveTypeAnnotation(this, node,

malformedIsError: malformedIsError,

deferredIsMalformed: deferredIsMalformed);

- registry.registerTypeUse(new TypeUse.checkedModeCheck(type));

+ if (!type.isDynamic) {

+ registry.registerTypeUse(new TypeUse.checkedModeCheck(type));

+ }

return type;

}