Moved Field Trial related code to CardsFieldTrial.

Moved Field Trial related code to CardsFieldTrial.

BUG=622975
Committed: https://crrev.com/ce73a63f5cc392bdca9cf78b99c5294d96b8ad44
Cr-Commit-Position: refs/heads/master@{#417325}

[PEConn, 2016-09-08 16:01:22]

peconn@chromium.org changed reviewers:
+ jkrcal@chromium.org, treib@chromium.org

[PEConn, 2016-09-08 16:01:23]

PTAL, just to make sure I haven't accidentally changed anything field trial
wise.

[jkrcal, 2016-09-08 16:10:19]

lgtm with a few nits

https://codereview.chromium.org/2323703003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsFieldTrial.java
(right):

https://codereview.chromium.org/2323703003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsFieldTrial.java:16:
public final class CardsFieldTrial {
What about CardsVariationParameters?

https://codereview.chromium.org/2323703003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsFieldTrial.java:17:
private static final String TAG = "CardFinchExperiments";
"Finch" is not a public name. What about CardsVariationParameters?

https://codereview.chromium.org/2323703003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsFieldTrial.java:37:
value = VariationsAssociatedData.getVariationParamValue(FIELD_TRIAL_NAME,
In the long run, we would like to get the parameters by feature name and not by
field trial name. This is not supported by VariationsAssociatedData, at the
moment :| Could you add a TODO(jkrcal) here, please?

[PEConn, 2016-09-08 16:24:02]

https://codereview.chromium.org/2323703003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsFieldTrial.java
(right):

https://codereview.chromium.org/2323703003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsFieldTrial.java:16:
public final class CardsFieldTrial {
On 2016/09/08 16:10:19, jkrcal wrote:
> What about CardsVariationParameters?

Done.

https://codereview.chromium.org/2323703003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsFieldTrial.java:17:
private static final String TAG = "CardFinchExperiments";
On 2016/09/08 16:10:19, jkrcal wrote:
> "Finch" is not a public name. What about CardsVariationParameters?

Good catch - I'd originally named the class that, remembered that it's not
public so renamed it, but forgot to update the TAG.

https://codereview.chromium.org/2323703003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsFieldTrial.java:37:
value = VariationsAssociatedData.getVariationParamValue(FIELD_TRIAL_NAME,
On 2016/09/08 16:10:19, jkrcal wrote:
> In the long run, we would like to get the parameters by feature name and not
by
> field trial name. This is not supported by VariationsAssociatedData, at the
> moment :| Could you add a TODO(jkrcal) here, please?

Done.

[Marc Treib, 2016-09-08 16:31:07]

LGTM, thanks for the cleanup!

[PEConn, 2016-09-08 16:31:52]

The CQ bit was checked by peconn@chromium.org

[PEConn, 2016-09-08 16:31:53]

The patchset sent to the CQ was uploaded after l-g-t-m from jkrcal@chromium.org
Link to the patchset: https://codereview.chromium.org/2323703003/#ps40001
(title: "Rename.")

[commit-bot: I haz the power, 2016-09-08 16:32:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 17:33:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-08 17:36:08]

Description was changed from

==========
Moved Field Trial related code to CardsFieldTrial.

BUG=622975
==========

to

==========
Moved Field Trial related code to CardsFieldTrial.

BUG=622975

Committed: https://crrev.com/ce73a63f5cc392bdca9cf78b99c5294d96b8ad44
Cr-Commit-Position: refs/heads/master@{#417325}
==========

[commit-bot: I haz the power, 2016-09-08 17:36:09]

Patchset 3 (id:??) landed as
https://crrev.com/ce73a63f5cc392bdca9cf78b99c5294d96b8ad44
Cr-Commit-Position: refs/heads/master@{#417325}