Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2257)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

Issue 2323703003: Moved Field Trial related code to CardsFieldTrial. (Closed)
Patch Set: Rename. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
index 406366296f8263fec3d2ab90e6be5e823b85f5f9..6bec52974f665a73dd6076a9facd4f31d6f23e77 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
@@ -33,17 +33,16 @@ import org.chromium.chrome.R;
import org.chromium.chrome.browser.favicon.FaviconHelper.FaviconImageCallback;
import org.chromium.chrome.browser.favicon.FaviconHelper.IconAvailabilityCallback;
import org.chromium.chrome.browser.ntp.DisplayStyleObserver;
-import org.chromium.chrome.browser.ntp.NewTabPage;
import org.chromium.chrome.browser.ntp.NewTabPageUma;
import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
import org.chromium.chrome.browser.ntp.UiConfig;
import org.chromium.chrome.browser.ntp.cards.CardViewHolder;
+import org.chromium.chrome.browser.ntp.cards.CardsVariationParameters;
import org.chromium.chrome.browser.ntp.cards.DisplayStyleObserverAdapter;
import org.chromium.chrome.browser.ntp.cards.ImpressionTracker;
import org.chromium.chrome.browser.ntp.cards.NewTabPageItem;
import org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
-import org.chromium.components.variations.VariationsAssociatedData;
import org.chromium.ui.WindowOpenDisposition;
import java.net.URI;
@@ -60,10 +59,6 @@ public class SnippetArticleViewHolder extends CardViewHolder implements Impressi
private static final String FAVICON_SERVICE_FORMAT =
"https://s2.googleusercontent.com/s2/favicons?domain=%s&src=chrome_newtab_mobile&sz=%d&alt=404";
- // The variation parameter to fetch the value from the favicon service.
- private static final String PARAMETER_FAVICON_SERVICE_NAME = "favicons_fetch_from_service";
- private static final String PARAMETER_DISABLED_VALUE = "off";
-
// ContextMenu item ids. These must be unique.
private static final int ID_OPEN_IN_NEW_WINDOW = 0;
private static final int ID_OPEN_IN_NEW_TAB = 1;
@@ -180,9 +175,7 @@ public class SnippetArticleViewHolder extends CardViewHolder implements Impressi
}
});
- mUseFaviconService =
- !PARAMETER_DISABLED_VALUE.equals(VariationsAssociatedData.getVariationParamValue(
- NewTabPage.FIELD_TRIAL_NAME, PARAMETER_FAVICON_SERVICE_NAME));
+ mUseFaviconService = CardsVariationParameters.isFaviconServiceEnabled();
}
@Override

Powered by Google App Engine
This is Rietveld 408576698