Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2323673002: [followup] Revert of [Bindings] Remove aggregation of generated binding code (Closed)

Created:
4 years, 3 months ago by peria
Modified:
4 years, 3 months ago
Reviewers:
bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Follow-up change of "Revert of [Bindings] Remove aggregation of generated binding code" The revert patch was committed twice, and broke build again. This CL is a revert of the second committed revert. Original CL: https://codereview.chromium.org/2318933002/ https://crrev.com/134a59bd48149d721ce06554570db1b2b5bdee55 Revert CL: https://codereview.chromium.org/2325583002 https://chromium.googlesource.com/chromium/src/+/d7586a77bd18573597cc48bbd2e0e6fb0fbc0fb9 https://chromium.googlesource.com/chromium/src/+/0f82e43808017ab95d877be86eb63fe1e4057e97 TBR=bashi@chromium.org,yukishiino@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/37d526452bd4bc224bfb2b5557bad97b3221d52d Cr-Commit-Position: refs/heads/master@{#417227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M third_party/WebKit/Source/bindings/scripts/scripts.gni View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323673002/1
4 years, 3 months ago (2016-09-08 09:06:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 09:07:44 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 09:09:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37d526452bd4bc224bfb2b5557bad97b3221d52d
Cr-Commit-Position: refs/heads/master@{#417227}

Powered by Google App Engine
This is Rietveld 408576698