Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2323653002: Remove SVGSVGElement.viewport attribute (Closed)

Created:
4 years, 3 months ago by Shanmuga Pandi
Modified:
4 years, 3 months ago
Reviewers:
pdr., rwlbuis, fs, timvolodine, foolip
CC:
fs, android-webview-reviews_chromium.org, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SVGSVGElement.viewport attribute SVGSVGElement.viewport removed from the spec. https://github.com/w3c/svgwg/commit/99a342c09dc0f8f164667d45d1c8486f0f87af8f Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/bFqDvZK2LVY BUG=395838 Committed: https://crrev.com/f742a3c284c19b78dbc337b641042a861e66d6b0 Cr-Commit-Position: refs/heads/master@{#417910}

Patch Set 1 #

Total comments: 1

Patch Set 2 : removed ::viewport() #

Total comments: 2

Patch Set 3 : fixed nits #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -57 lines) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/detached-outermost-svg-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/immutable-properties.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/immutable-properties-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/immutable-properties-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/script-tests/immutable-properties.js View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 1 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.idl View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (11 generated)
Shanmuga Pandi
PTAL!!!
4 years, 3 months ago (2016-09-08 07:22:31 UTC) #3
fs
lgtm
4 years, 3 months ago (2016-09-08 08:08:01 UTC) #4
fs
https://codereview.chromium.org/2323653002/diff/1/third_party/WebKit/Source/core/svg/SVGSVGElement.idl File third_party/WebKit/Source/core/svg/SVGSVGElement.idl (left): https://codereview.chromium.org/2323653002/diff/1/third_party/WebKit/Source/core/svg/SVGSVGElement.idl#oldcode31 third_party/WebKit/Source/core/svg/SVGSVGElement.idl:31: [DeprecateAs=V8SVGSVGElement_Viewport_AttributeGetter] readonly attribute SVGRect viewport; Should be possible to ...
4 years, 3 months ago (2016-09-08 08:09:39 UTC) #5
Shanmuga Pandi
On 2016/09/08 08:09:39, fs wrote: > https://codereview.chromium.org/2323653002/diff/1/third_party/WebKit/Source/core/svg/SVGSVGElement.idl > File third_party/WebKit/Source/core/svg/SVGSVGElement.idl (left): > > https://codereview.chromium.org/2323653002/diff/1/third_party/WebKit/Source/core/svg/SVGSVGElement.idl#oldcode31 > ...
4 years, 3 months ago (2016-09-08 09:33:01 UTC) #6
fs
https://codereview.chromium.org/2323653002/diff/20001/third_party/WebKit/Source/core/svg/SVGSVGElement.h File third_party/WebKit/Source/core/svg/SVGSVGElement.h (right): https://codereview.chromium.org/2323653002/diff/20001/third_party/WebKit/Source/core/svg/SVGSVGElement.h#newcode53 third_party/WebKit/Source/core/svg/SVGSVGElement.h:53: Nit: Drop this blank line as well.
4 years, 3 months ago (2016-09-08 10:15:39 UTC) #7
Shanmuga Pandi
https://codereview.chromium.org/2323653002/diff/20001/third_party/WebKit/Source/core/svg/SVGSVGElement.h File third_party/WebKit/Source/core/svg/SVGSVGElement.h (right): https://codereview.chromium.org/2323653002/diff/20001/third_party/WebKit/Source/core/svg/SVGSVGElement.h#newcode53 third_party/WebKit/Source/core/svg/SVGSVGElement.h:53: On 2016/09/08 10:15:38, fs wrote: > Nit: Drop this ...
4 years, 3 months ago (2016-09-08 14:17:19 UTC) #8
timvolodine
android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt -- rs lgtm
4 years, 3 months ago (2016-09-08 14:38:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323653002/40001
4 years, 3 months ago (2016-09-08 16:18:33 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/65881) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-08 16:20:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323653002/60001
4 years, 3 months ago (2016-09-12 05:35:47 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/257318)
4 years, 3 months ago (2016-09-12 05:41:43 UTC) #19
Shanmuga Pandi
On 2016/09/12 05:41:43, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 3 months ago (2016-09-12 08:49:33 UTC) #20
foolip
lgtm
4 years, 3 months ago (2016-09-12 10:22:05 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323653002/60001
4 years, 3 months ago (2016-09-12 10:22:40 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-12 10:26:46 UTC) #25
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 10:28:17 UTC) #27
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/f742a3c284c19b78dbc337b641042a861e66d6b0
Cr-Commit-Position: refs/heads/master@{#417910}

Powered by Google App Engine
This is Rietveld 408576698