third_party/WebKit/Source/core/svg/SVGSVGElement.cpp - Issue 2323653002: Remove SVGSVGElement.viewport attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

Issue 2323653002: Remove SVGSVGElement.viewport attribute (Closed)

Patch Set: rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

index 80aa89457d97d9a038f7188a390fa88bb6b1b73b..924794d6fba2ffb9d6ba7901737c9581fcd63892 100644

--- a/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

@@ -88,13 +88,6 @@ SVGSVGElement::~SVGSVGElement()

{

}

-SVGRectTearOff* SVGSVGElement::viewport() const

- // FIXME: This method doesn't follow the spec and is basically untested. Parent documents are not considered here.

- // As we have no test coverage for this, we're going to disable it completly for now.

- return SVGRectTearOff::create(SVGRect::create(), 0, PropertyIsNotAnimVal);

SVGViewSpec* SVGSVGElement::currentView()

{

if (!m_viewSpec)