Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2323233003: Pass rietveld as the default patch_storage. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio, rmistry
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Pass rietveld as the default patch_storage. Passing around empty strings as command line arguments requires us to be really careful about command line quoting, parsing, etc. It seems easy enough here to just supply the implied value. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323233003 Committed: https://skia.googlesource.com/skia/+/0973a371ecb55a97d84d18c236df6180bca41e6d

Patch Set 1 #

Messages

Total messages: 14 (7 generated)
mtklein_C
4 years, 3 months ago (2016-09-09 19:08:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323233003/1
4 years, 3 months ago (2016-09-09 19:08:57 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-09 19:08:59 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
4 years, 3 months ago (2016-09-10 01:08:58 UTC) #9
rmistry
lgtm
4 years, 3 months ago (2016-09-10 02:01:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323233003/1
4 years, 3 months ago (2016-09-15 15:04:18 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 15:27:41 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0973a371ecb55a97d84d18c236df6180bca41e6d

Powered by Google App Engine
This is Rietveld 408576698