Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: infra/bots/recipe_modules/vars/api.py

Issue 2323233003: Pass rietveld as the default patch_storage. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_perf.expected/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 # pylint: disable=W0201 6 # pylint: disable=W0201
7 7
8 8
9 from recipe_engine import recipe_api 9 from recipe_engine import recipe_api
10 10
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 self.configuration = CONFIG_RELEASE 101 self.configuration = CONFIG_RELEASE
102 else: 102 else:
103 self.configuration = self.builder_cfg.get('configuration', CONFIG_DEBUG) 103 self.configuration = self.builder_cfg.get('configuration', CONFIG_DEBUG)
104 arch = (self.builder_cfg.get('arch') or self.builder_cfg.get('target_arch')) 104 arch = (self.builder_cfg.get('arch') or self.builder_cfg.get('target_arch'))
105 if ('Win' in self.builder_cfg.get('os', '') and arch == 'x86_64'): 105 if ('Win' in self.builder_cfg.get('os', '') and arch == 'x86_64'):
106 self.configuration += '_x64' 106 self.configuration += '_x64'
107 107
108 self.default_env.update({'SKIA_OUT': self.skia_out, 108 self.default_env.update({'SKIA_OUT': self.skia_out,
109 'BUILDTYPE': self.configuration}) 109 'BUILDTYPE': self.configuration})
110 self.is_trybot = self.builder_cfg['is_trybot'] 110 self.is_trybot = self.builder_cfg['is_trybot']
111 self.patch_storage = self.m.properties.get('patch_storage', '') 111 self.patch_storage = self.m.properties.get('patch_storage', 'rietveld')
112 self.issue = None 112 self.issue = None
113 self.patchset = None 113 self.patchset = None
114 if self.is_trybot: 114 if self.is_trybot:
115 if self.patch_storage == 'gerrit': 115 if self.patch_storage == 'gerrit':
116 self.issue = self.m.properties['event.change.number'] 116 self.issue = self.m.properties['event.change.number']
117 self.patchset = self.m.properties['event.patchSet.ref'].split('/')[-1] 117 self.patchset = self.m.properties['event.patchSet.ref'].split('/')[-1]
118 else: 118 else:
119 self.issue = self.m.properties['issue'] 119 self.issue = self.m.properties['issue']
120 self.patchset = self.m.properties['patchset'] 120 self.patchset = self.m.properties['patchset']
121 self.dm_dir = self.m.path.join( 121 self.dm_dir = self.m.path.join(
(...skipping 16 matching lines...) Expand all
138 for s in skip_upload_bots: 138 for s in skip_upload_bots:
139 if s in self.m.properties['buildername']: 139 if s in self.m.properties['buildername']:
140 upload_dm_results = False 140 upload_dm_results = False
141 break 141 break
142 return upload_dm_results 142 return upload_dm_results
143 143
144 @property 144 @property
145 def upload_perf_results(self): 145 def upload_perf_results(self):
146 # TODO(borenet): Move this into the swarm_perf recipe. 146 # TODO(borenet): Move this into the swarm_perf recipe.
147 return ('Release' in self.m.properties['buildername']) 147 return ('Release' in self.m.properties['buildername'])
OLDNEW
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_perf.expected/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698