Add a script to update the expected errors for

Add a script to update the expected errors for
net/data/verify_certificate_chain_unittest/* test data.

It works by scraping stdout of a failed unit-test run, and modifying the
.pem ad .py files accordingly.

BUG=634443
NOPRESUBMIT=true

Committed: https://crrev.com/0719d9b41fdc1d25eba6e6f2177a3cbd5cc56b52
Cr-Commit-Position: refs/heads/master@{#418106}

[eroman, 2016-09-09 05:06:20]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 05:06:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-09-09 05:06:40]

Description was changed from

==========
Add a script to update the expected errors for
net/data/verify_certificate_chain_unittest/* test data.

It works by scaping stdout of a failed unit-test run, and modifying the
.pem ad .py files accordigly.

BUG=634443
==========

to

==========
Add a script to update the expected errors for
net/data/verify_certificate_chain_unittest/* test data.

It works by scraping stdout of a failed unit-test run, and modifying the
.pem ad .py files accordigly.

BUG=634443
==========

[eroman, 2016-09-09 05:06:50]

Description was changed from

==========
Add a script to update the expected errors for
net/data/verify_certificate_chain_unittest/* test data.

It works by scraping stdout of a failed unit-test run, and modifying the
.pem ad .py files accordigly.

BUG=634443
==========

to

==========
Add a script to update the expected errors for
net/data/verify_certificate_chain_unittest/* test data.

It works by scraping stdout of a failed unit-test run, and modifying the
.pem ad .py files accordingly.

BUG=634443
==========

[eroman, 2016-09-09 05:08:01]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 05:08:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-09-09 05:09:50]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 05:10:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-09-09 05:12:24]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org

[eroman, 2016-09-09 05:12:25]

I realize this script is a bit silly, but it is tedious to update all the files
whenever changing the errors or textual error format.

(Follow-up CLs change the error textual representations, and I used this script
to update the data files)

[commit-bot: I haz the power, 2016-09-09 05:15:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 05:15:45]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mattm, 2016-09-09 22:18:54]

https://codereview.chromium.org/2323223002/diff/40001/net/data/verify_certifi...
File net/data/verify_certificate_chain_unittest/rebase-errors.py (right):

https://codereview.chromium.org/2323223002/diff/40001/net/data/verify_certifi...
net/data/verify_certificate_chain_unittest/rebase-errors.py:108: contents =
replace_string(contents, result.start(1), result.end(1),
could use re.sub instead of re.search + replace_string

https://codereview.chromium.org/2323223002/diff/40001/net/data/verify_certifi...
net/data/verify_certificate_chain_unittest/rebase-errors.py:137: test_stdout =
read_file_to_string(sys.argv[1])
what do you think about reading from sys.stdin instead of a file, so you can
just pipe the test output directly to the script?

[eroman, 2016-09-09 23:16:26]

https://codereview.chromium.org/2323223002/diff/40001/net/data/verify_certifi...
File net/data/verify_certificate_chain_unittest/rebase-errors.py (right):

https://codereview.chromium.org/2323223002/diff/40001/net/data/verify_certifi...
net/data/verify_certificate_chain_unittest/rebase-errors.py:108: contents =
replace_string(contents, result.start(1), result.end(1),
On 2016/09/09 22:18:54, mattm wrote:
> could use re.sub instead of re.search + replace_string

My concern with re.sub() is that it processes backslash characters with special
meaning. So if |actual_errors| had any it may break.

https://codereview.chromium.org/2323223002/diff/40001/net/data/verify_certifi...
net/data/verify_certificate_chain_unittest/rebase-errors.py:137: test_stdout =
read_file_to_string(sys.argv[1])
On 2016/09/09 22:18:54, mattm wrote:
> what do you think about reading from sys.stdin instead of a file, so you can
> just pipe the test output directly to the script?

Sure, will do.

[mattm, 2016-09-09 23:22:21]

https://codereview.chromium.org/2323223002/diff/40001/net/data/verify_certifi...
File net/data/verify_certificate_chain_unittest/rebase-errors.py (right):

https://codereview.chromium.org/2323223002/diff/40001/net/data/verify_certifi...
net/data/verify_certificate_chain_unittest/rebase-errors.py:108: contents =
replace_string(contents, result.start(1), result.end(1),
On 2016/09/09 23:16:25, eroman wrote:
> On 2016/09/09 22:18:54, mattm wrote:
> > could use re.sub instead of re.search + replace_string
> 
> My concern with re.sub() is that it processes backslash characters with
special
> meaning. So if |actual_errors| had any it may break.

ah, I forgot that. I guess there is the 2nd form of re.sub where you pass a
function instead of a string. With a lambda it might not be too ugly. But I'm
fine either way.

[eroman, 2016-09-10 00:22:02]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-10 00:22:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-09-10 00:22:39]

https://codereview.chromium.org/2323223002/diff/40001/net/data/verify_certifi...
File net/data/verify_certificate_chain_unittest/rebase-errors.py (right):

https://codereview.chromium.org/2323223002/diff/40001/net/data/verify_certifi...
net/data/verify_certificate_chain_unittest/rebase-errors.py:108: contents =
replace_string(contents, result.start(1), result.end(1),
On 2016/09/09 23:22:21, mattm wrote:
> On 2016/09/09 23:16:25, eroman wrote:
> > On 2016/09/09 22:18:54, mattm wrote:
> > > could use re.sub instead of re.search + replace_string
> > 
> > My concern with re.sub() is that it processes backslash characters with
> special
> > meaning. So if |actual_errors| had any it may break.
> 
> ah, I forgot that. I guess there is the 2nd form of re.sub where you pass a
> function instead of a string. With a lambda it might not be too ugly. But I'm
> fine either way.

Left unchanged.

https://codereview.chromium.org/2323223002/diff/40001/net/data/verify_certifi...
net/data/verify_certificate_chain_unittest/rebase-errors.py:137: test_stdout =
read_file_to_string(sys.argv[1])
On 2016/09/09 23:16:26, eroman wrote:
> On 2016/09/09 22:18:54, mattm wrote:
> > what do you think about reading from sys.stdin instead of a file, so you can
> > just pipe the test output directly to the script?
> 
> Sure, will do.

Done.

[commit-bot: I haz the power, 2016-09-10 00:31:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 00:31:06]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mattm, 2016-09-10 00:46:54]

lgtm

[eroman, 2016-09-10 01:29:05]

Description was changed from

==========
Add a script to update the expected errors for
net/data/verify_certificate_chain_unittest/* test data.

It works by scraping stdout of a failed unit-test run, and modifying the
.pem ad .py files accordingly.

BUG=634443
==========

to

==========
Add a script to update the expected errors for
net/data/verify_certificate_chain_unittest/* test data.

It works by scraping stdout of a failed unit-test run, and modifying the
.pem ad .py files accordingly.

BUG=634443
NOPRESUBMIT=true
==========

[eroman, 2016-09-10 01:29:23]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2016-09-10 01:29:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 02:52:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 02:52:12]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[eroman, 2016-09-12 22:20:54]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2016-09-12 22:21:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 23:42:22]

Description was changed from

==========
Add a script to update the expected errors for
net/data/verify_certificate_chain_unittest/* test data.

It works by scraping stdout of a failed unit-test run, and modifying the
.pem ad .py files accordingly.

BUG=634443
NOPRESUBMIT=true
==========

to

==========
Add a script to update the expected errors for
net/data/verify_certificate_chain_unittest/* test data.

It works by scraping stdout of a failed unit-test run, and modifying the
.pem ad .py files accordingly.

BUG=634443
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2016-09-12 23:42:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-12 23:45:48]

Description was changed from

==========
Add a script to update the expected errors for
net/data/verify_certificate_chain_unittest/* test data.

It works by scraping stdout of a failed unit-test run, and modifying the
.pem ad .py files accordingly.

BUG=634443
NOPRESUBMIT=true
==========

to

==========
Add a script to update the expected errors for
net/data/verify_certificate_chain_unittest/* test data.

It works by scraping stdout of a failed unit-test run, and modifying the
.pem ad .py files accordingly.

BUG=634443
NOPRESUBMIT=true

Committed: https://crrev.com/0719d9b41fdc1d25eba6e6f2177a3cbd5cc56b52
Cr-Commit-Position: refs/heads/master@{#418106}
==========

[commit-bot: I haz the power, 2016-09-12 23:45:49]

Patchset 4 (id:??) landed as
https://crrev.com/0719d9b41fdc1d25eba6e6f2177a3cbd5cc56b52
Cr-Commit-Position: refs/heads/master@{#418106}