Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2180)

Unified Diff: net/data/verify_certificate_chain_unittest/common.py

Issue 2323223002: Add a script to update the expected errors for (Closed)
Patch Set: Read from stdin if no argument Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/data/verify_certificate_chain_unittest/generate-expired-intermediate.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/data/verify_certificate_chain_unittest/common.py
diff --git a/net/data/verify_certificate_chain_unittest/common.py b/net/data/verify_certificate_chain_unittest/common.py
index 37d4d5b0bf153a689d158b675ee6a84b23c33cbe..c5bcd9729986c1011f2062033565531500e24809 100755
--- a/net/data/verify_certificate_chain_unittest/common.py
+++ b/net/data/verify_certificate_chain_unittest/common.py
@@ -453,9 +453,8 @@ def write_test_file(description, chain, trust_anchor, utc_time, verify_result,
verify_result_string = 'SUCCESS' if verify_result else 'FAIL'
test_data += '\n' + text_data_to_pem('VERIFY_RESULT', verify_result_string)
- # TODO(eroman): Make the consumer pass errors as a string.
if errors is not None:
- test_data += '\n' + text_data_to_pem('ERRORS', '\n'.join(errors))
+ test_data += '\n' + text_data_to_pem('ERRORS', errors)
write_string_to_file(test_data, out_pem if out_pem else g_out_pem)
« no previous file with comments | « no previous file | net/data/verify_certificate_chain_unittest/generate-expired-intermediate.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698