Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2323173002: Remove several references to JavaFile (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -17 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 6 chunks +14 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/single_context_manager_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/utils.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/source/embedder.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/test/utils.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 3 months ago (2016-09-09 00:17:37 UTC) #2
scheglov
LGTM
4 years, 3 months ago (2016-09-09 00:40:30 UTC) #3
Brian Wilkerson
4 years, 3 months ago (2016-09-09 14:45:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fe02411930d6573a1e576461011b167c8e0d76d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698