PlzNavigate: make ctrl+click works.

PlzNavigate: make ctrl+click works.

Opening a link in a new tab/window was broken with PlzNavigate.

This CL solves the majority of broken tests. There is still 3
browser_tests that doesn't work properly yet, but it seems to me this
is unrelated to click modifiers (ctrl/shift/meta+click).

Timeout:
    ReferrerPolicyTest.HttpLeftClickRedirectToHTTPOriginWhenCrossOrigin

Flaky fail:
    ClickModifierTest.WindowOpenControlShiftClickTest
    ClickModifierTest.WindowOpenBasicClickTest

BUG=644116
R=clamy@chromium.org

Committed: https://crrev.com/a82b237354e75482b5857f11644877611896fa58
Cr-Commit-Position: refs/heads/master@{#418990}

[arthursonzogni, 2016-09-09 08:25:26]

Hi Camille,

Could you please take a look at this CL ?

Thanks,
Arthur

[clamy, 2016-09-09 15:28:01]

Thanks!

https://codereview.chromium.org/2323153003/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2323153003/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:5090: info.defaultPolicy ==
blink::WebNavigationPolicyCurrentTab) {
I think we should still have a special case for PlzNavigate all the time, but
set up like this:
if (IsBrowserSideNavigationEnabled() &&
    info.urlRequest.checkForBrowserSideNavigation()) {
  if (info.defaultPolicy == blink::WebNavigationPolicyCurrentTab) {
    BeginNavigation(info);
    return blink::WebNavigationPolicyHandledByClient;
  } else {
    loadURLExternally(...);
    return either WebNavigationPolicyHandledByClient or
WebNavigationPolicyIgnore
  }
}

[arthursonzogni, 2016-09-15 00:28:27]

Thanks!
I fixed it.

[clamy, 2016-09-15 12:46:44]

Thanks! Lgtm.

[arthursonzogni, 2016-09-15 20:12:35]

The CQ bit was checked by arthursonzogni@chromium.org

[commit-bot: I haz the power, 2016-09-15 20:13:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 21:47:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-15 21:51:05]

Description was changed from

==========
PlzNavigate: make ctrl+click works.

Opening a link in a new tab/window was broken with PlzNavigate.

This CL solves the majority of broken tests. There is still 3
browser_tests that doesn't work properly yet, but it seems to me this
is unrelated to click modifiers (ctrl/shift/meta+click).

Timeout:
    ReferrerPolicyTest.HttpLeftClickRedirectToHTTPOriginWhenCrossOrigin

Flaky fail:
    ClickModifierTest.WindowOpenControlShiftClickTest
    ClickModifierTest.WindowOpenBasicClickTest

BUG=644116

R=clamy@chromium.org
==========

to

==========
PlzNavigate: make ctrl+click works.

Opening a link in a new tab/window was broken with PlzNavigate.

This CL solves the majority of broken tests. There is still 3
browser_tests that doesn't work properly yet, but it seems to me this
is unrelated to click modifiers (ctrl/shift/meta+click).

Timeout:
    ReferrerPolicyTest.HttpLeftClickRedirectToHTTPOriginWhenCrossOrigin

Flaky fail:
    ClickModifierTest.WindowOpenControlShiftClickTest
    ClickModifierTest.WindowOpenBasicClickTest

BUG=644116

R=clamy@chromium.org

Committed: https://crrev.com/a82b237354e75482b5857f11644877611896fa58
Cr-Commit-Position: refs/heads/master@{#418990}
==========

[commit-bot: I haz the power, 2016-09-15 21:51:05]

Patchset 2 (id:??) landed as
https://crrev.com/a82b237354e75482b5857f11644877611896fa58
Cr-Commit-Position: refs/heads/master@{#418990}